[#34310] - [4.0] options sidebar
- Fixed in Code Base
- 6 Jun 2021
- Medium
- Build: 4.0-dev
- # 34310
- Diff
- brianteeman:sidebar
User tests: Successful: Unsuccessful:
Adds a more visible highlight for the active option
this is an scss change so dont forget to rebuild
pr for #34305
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) NPM Change |
Heading is not readable.
| Labels |
Added:
NPM Resource Changed
?
|
||
| Category | Administration Templates (admin) NPM Change | ⇒ | Administration com_config Templates (admin) NPM Change |
@brianteeman Sorry I forget to type npm run build:css in terminal to rebuild the files.
Can you make the entire row clickable and not just text?
any suggestions
Add display: block; here should do the trick.
a {
font-weight: $font-weight-normal;
color: var(--atum-text-dark);
text-decoration: none;
Edit: This is an issue before the PR: Also there is flickering between cursor and hand when moving up and down through the items.
added the block - i can see the cursor thing but cant see the fix
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34310.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34310.
If you want to fix all the comments, and also make it look better, then use this:
// Sidebar
.sidebar-nav {
padding: 1rem 0 1rem 2rem;
li {
font-size: .9rem;
font-weight: $font-weight-bold;
&.divider {
margin: .3rem 0;
}
a {
padding: .25rem;
display: block;
font-weight: $font-weight-normal;
color: var(--atum-text-dark);
text-decoration: none;
&::before {
margin-inline-end: .5rem;
font-family: "Font Awesome 5 Free";
font-weight: 900;
content: "\f054";
[dir="rtl"] & {
content: "\f053";
}
}
}
&.item:hover, &.active {
background-color: var(--atum-bg-dark-60);
a {
color: var(--atum-text-light);
}
}
}
}
I have tested this item
Perfect!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34310.
I have tested this item
Thanks all for creating, comment and test the pull request.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34310.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34310.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-06-06 21:08:31 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
?
|
||
Thanks!
great thanks
I have tested this item✅ successfully on b62ed89
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34310.