[#34301] - [4] use and not when using nl2br
- Fixed in Code Base
- 31 May 2021
- Medium
- Build: 4.0-dev
- # 34301
- Diff
- PhilETaylor:nl2br
User tests: Successful: Unsuccessful:
Summary of Changes
Joomla 4 should use <br> throughout apparently.
In several places, including the new Mail Templates, we use nl2br which has a second parameter called use_xhtml which by default is set to true - docs: https://www.php.net/manual/en/function.nl2br.php
This pr sets all instances to not use xhtml and thus generate <br> and not <br /> tags
Testing Instructions
Code review is easiest
For Mail Templates, edit options and set Mail Format = HTML, but dont edit any of the templates to provide a HTML version, letting Joomla convert the language string (which is plain text) into "magic" HTML - send an email and inspect its source
Actual result BEFORE applying this Pull Request
Example
Expected result AFTER applying this Pull Request
Any use of nl2br in Joomla 4 renders <br> and not <br /> tags
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_users Front End com_contact Libraries |
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34301.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34301.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-31 07:55:59 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
?
|
||
Thanks!
I have tested this item✅ successfully on c681683
nice spot
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34301.