? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
30 May 2021

Summary of Changes

As title says. This description is useful and is used in J3.

Screen Shot 2021-05-30 at 16 59 12

Testing Instructions

Create a custom admin menu with no preset.
Create menu items in that menu.
Among them create a Separator menu item

Actual result BEFORE applying this Pull Request

Screen Shot 2021-05-30 at 17 11 58

Expected result AFTER applying this Pull Request

Screen Shot 2021-05-30 at 17 39 33

EDIT: String changed to
COM_MENUS_ITEM_FIELD_TEXT_SEPARATOR_DESC="When set to 'No' a divider will be displayed instead."

avatar infograf768 infograf768 - open - 30 May 2021
avatar infograf768 infograf768 - change - 30 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 May 2021
Category Administration Language & Strings
avatar infograf768
infograf768 - comment - 30 May 2021

@brianteeman

In fact, just found out the second part is also wrong in J4.

When selecting No, and even if the menu title contains dashes, we get a divider.

Screen Shot 2021-05-30 at 17 44 26

Please suggest a change something as
"If set to No, a divider will be used."

Then we can play a bit with the CSS as it is not very visible.

avatar brianteeman
brianteeman - comment - 30 May 2021

When set to no a divider will be displayed instead

avatar infograf768 infograf768 - change - 30 May 2021
Labels Added: ? ?
avatar infograf768 infograf768 - change - 30 May 2021
The description was changed
avatar infograf768 infograf768 - edited - 30 May 2021
avatar infograf768
infograf768 - comment - 30 May 2021

Done:
COM_MENUS_ITEM_FIELD_TEXT_SEPARATOR_DESC="When set to 'No' a divider will be displayed instead."

avatar infograf768
infograf768 - comment - 30 May 2021

Note:
CSS could be modified to

.main-nav .divider {
    height: 1px;
    margin: 0 0 0 48px;
    list-style: none;
    background-color: var(--atum-bg-dark-30);  // instead of 60
}

as done for Administrator Menu divider.

avatar brianteeman
brianteeman - comment - 30 May 2021

Why not change this to
before

avatar infograf768
infograf768 - comment - 30 May 2021

Please do if you prefer. I will gladfully delete this.

avatar brianteeman
brianteeman - comment - 30 May 2021

see #34296

avatar wilsonge wilsonge - change - 30 May 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-05-30 23:10:33
Closed_By wilsonge
avatar wilsonge wilsonge - close - 30 May 2021

Add a Comment

Login with GitHub to post a comment