? ? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
30 May 2021

Summary of Changes

Apply PHPCS to the build tools and remove unused md5/sha1 hashes

Testing Instructions

  • make sure the builds (below this page) still works.
  • code review

Actual result BEFORE applying this Pull Request

Some phpcs issues as well as the generation of the not used md5 & sha1 hashes

Expected result AFTER applying this Pull Request

Lesser phpcs issues as well as no md5 nor sha1 hashes anymore

Documentation Changes Required

none

avatar zero-24 zero-24 - open - 30 May 2021
avatar zero-24 zero-24 - change - 30 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 May 2021
Category Repository
avatar PhilETaylor
PhilETaylor - comment - 30 May 2021
avatar zero-24 zero-24 - change - 30 May 2021
Labels Added: ?
avatar richard67 richard67 - test_item - 31 May 2021 - Tested successfully
avatar richard67
richard67 - comment - 31 May 2021

I have tested this item successfully on 8958b6c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34290.

avatar Quy Quy - test_item - 31 May 2021 - Tested successfully
avatar Quy
Quy - comment - 31 May 2021

I have tested this item successfully on 8958b6c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34290.

avatar Quy Quy - change - 31 May 2021
Status Pending Ready to Commit
avatar Quy
Quy - comment - 31 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34290.

avatar HLeithner HLeithner - change - 1 Jun 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-06-01 16:08:29
Closed_By HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 1 Jun 2021
avatar HLeithner HLeithner - merge - 1 Jun 2021

Add a Comment

Login with GitHub to post a comment