[#34275] - Pettrify 4.0-dev/administrator/templates/atum/scss/blocks/_alerts.scss
- Closed
- 29 May 2021
- Medium
- Build: staging
- # 34275
- Diff
- Stuartemk:4.0-dev
- Success Download Prebuilt packages are available for download. Details
- Success continuous-integration/appveyor/branch AppVeyor build succeeded Details
- Success continuous-integration/drone/push Build is passing Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Stuartemk#1
Summary of Changes
Prettify the css and js files allows a better reading and understanding of the code so you can develop faster and avoid errors.
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests Repository Administration |
@Stuartemk It seems you have selected the wrong target branch (staging instead of 4.0-dev) when making thin PR. I would expect PR authors to check their PR's changes on GitHub and notice such things.
Thank you for your responses. It is clear that I made a terrible mistake, and that these PRs are totally wrong, so I close them right now. It was only a single file to modify.
Although the error is so obvious, the answers could also be less aggressive, since for that reason there are almost no contributors, not very tolerant answers take away the desire to contribute.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-29 22:27:09 |
| Closed_By | ⇒ | Stuartemk | |
| Labels |
Added:
?
?
|
||
@Stuartemk Where have you seen anything aggressive?
You made this Joomla 4 pull request against the joomla 3 branch