? ? Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
29 May 2021

Fix for #30798

Summary of Changes

Fixing incorrect selection when clicking on the row with disabled module.
This enable check box for disabled module, the same behavior as for Menu item when component is disabled.

Testing Instructions

Create Custom HTML Module. (or any other unlocked module)
Go to extension manager and disable "Custom Module".
Go back to module overview, and try select this module.

Actual result BEFORE applying this Pull Request

The next row will be selected. You cannot delete "disabled" record.

Expected result AFTER applying this Pull Request

A correct row will be selected. You able to delete "disabled" record.

Documentation Changes Required

nope

avatar Fedik Fedik - open - 29 May 2021
avatar Fedik Fedik - change - 29 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 May 2021
Category Administration com_modules
avatar infograf768 infograf768 - test_item - 29 May 2021 - Tested successfully
avatar infograf768
infograf768 - comment - 29 May 2021

I have tested this item successfully on d285cd2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34273.

avatar chmst
chmst - comment - 29 May 2021

This resolves the drag and drop issue. But I'd prefer to remove the link to the module for editing

avatar Fedik
Fedik - comment - 29 May 2021

There no reason for it.

It like editing Unpublished/Outdated Article, it still fine.

avatar infograf768
infograf768 - comment - 29 May 2021

No reason indeed, but if we want, the code would be something like:
line 133-155

<th scope="row" class="has-context">
							<div>
								<?php if ($item->enabled == 0) : ?>
									<?php echo $this->escape($item->title); ?>
								<?php else : ?>
									<?php if ($item->checked_out) : ?>
										<?php echo HTMLHelper::_('jgrid.checkedout', $i, $item->editor, $item->checked_out_time, 'modules.', $canCheckin); ?>
									<?php endif; ?>
									<?php if ($canEdit) : ?>
										<a href="<?php echo Route::_('index.php?option=com_modules&task=module.edit&id=' . (int) $item->id); ?>" title="<?php echo Text::_('JACTION_EDIT'); ?> <?php echo $this->escape($item->title); ?>">
											<?php echo $this->escape($item->title); ?></a>
									<?php else : ?>
										<?php echo $this->escape($item->title); ?>
									<?php endif; ?>
								<?php endif; ?>

								<?php if (!empty($item->note)) : ?>
									<div class="small">
										<?php echo Text::sprintf('JGLOBAL_LIST_NOTE', $this->escape($item->note)); ?>
									</div>
								<?php endif; ?>
							</div>
						</th>
avatar richard67
richard67 - comment - 29 May 2021

@Fedik Does this solve issue #30798 completely so the issue can be closed?

avatar Quy Quy - test_item - 29 May 2021 - Tested successfully
avatar Quy
Quy - comment - 29 May 2021

I have tested this item successfully on d285cd2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34273.

avatar richard67 richard67 - change - 29 May 2021
Status Pending Ready to Commit
Labels Added: ?
avatar richard67
richard67 - comment - 29 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34273.

avatar infograf768 infograf768 - close - 30 May 2021
avatar infograf768 infograf768 - merge - 30 May 2021
avatar infograf768 infograf768 - change - 30 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-30 05:56:40
Closed_By infograf768
Labels Added: ?
avatar infograf768
infograf768 - comment - 30 May 2021

tks

Add a Comment

Login with GitHub to post a comment