User tests: Successful: Unsuccessful:
Fix for #30798
Fixing incorrect selection when clicking on the row with disabled module.
This enable check box for disabled module, the same behavior as for Menu item when component is disabled.
Create Custom HTML Module. (or any other unlocked module)
Go to extension manager and disable "Custom Module".
Go back to module overview, and try select this module.
The next row will be selected. You cannot delete "disabled" record.
A correct row will be selected. You able to delete "disabled" record.
nope
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_modules |
This resolves the drag and drop issue. But I'd prefer to remove the link to the module for editing
There no reason for it.
It like editing Unpublished/Outdated Article, it still fine.
No reason indeed, but if we want, the code would be something like:
line 133-155
<th scope="row" class="has-context">
<div>
<?php if ($item->enabled == 0) : ?>
<?php echo $this->escape($item->title); ?>
<?php else : ?>
<?php if ($item->checked_out) : ?>
<?php echo HTMLHelper::_('jgrid.checkedout', $i, $item->editor, $item->checked_out_time, 'modules.', $canCheckin); ?>
<?php endif; ?>
<?php if ($canEdit) : ?>
<a href="<?php echo Route::_('index.php?option=com_modules&task=module.edit&id=' . (int) $item->id); ?>" title="<?php echo Text::_('JACTION_EDIT'); ?> <?php echo $this->escape($item->title); ?>">
<?php echo $this->escape($item->title); ?></a>
<?php else : ?>
<?php echo $this->escape($item->title); ?>
<?php endif; ?>
<?php endif; ?>
<?php if (!empty($item->note)) : ?>
<div class="small">
<?php echo Text::sprintf('JGLOBAL_LIST_NOTE', $this->escape($item->note)); ?>
</div>
<?php endif; ?>
</div>
</th>
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
Labels |
Added:
?
|
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-30 05:56:40 |
Closed_By | ⇒ | infograf768 | |
Labels |
Added:
?
|
tks
I have tested this item✅ successfully on d285cd2
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34273.