@HLeithner @nibra Shouldn't this change be made upstream here https://github.com/joomla-framework/filesystem and then a new release of the upstream package should be fetched into the CMS? Or shall the change be made at both places? Or is it ok to make it only here like this PR does?

@richard67 This should be done upstream and not here.

Should I request the pull on the upstream package? If so, its no problem.

I was not sure wheter the use of JDEBUG constant actually belongs to the filesystem sources or not...

passing METHOD as a string in the exception message is simply wrong too - an Exception knows what method threw it, users should never be shown internal tokens like filenames and method names :) We have been removing those from Joomla.

@PhilETaylor not sure if I missed something but I changed the message only for the debug mode. Throwing errors at developers that are meaningless is quite pointless. The exception stack in debug mode tells me enought to know which method throwed what from where but in this case actually nothing about the file that is the reason for the exception.

The Framework is completely unaware of JDEBUG.

@echterhoff Sorry if I confused you, I was making a general point about the whole throwing of exceptions and not specifically about your changes.

The point I was making is that this:

throw new FilesystemException(__METHOD__ . ': Failed deleting inaccessible file ' . $filename);

should be this:

throw new FilesystemException('Failed deleting inaccessible file ' . $filename);

and that the __METHOD__ should never be part of a string message from an exception (and even more importantly, should never then be rendered to the user to tell the user the exception - The internals of code should never be shown to users - when was the last time you got an error page on Amazon.com and they told you that the error was in a method named chargeTheUser20PercentMore() .. you would never see PayPal.com show you their method names or class names... but yet Joomla and Joomla Framework classes do this a lot...

and that the __METHOD__ should never be part of a string message from an exception (and even more importantly, should never then be rendered to the user to tell the user the exception - The internals of code should never be shown to users - when was the last time you got an error page on Amazon.com and they told you that the error was in a method named chargeTheUser20PercentMore() .. you would never see PayPal.com show you their method names or class names... but yet Joomla and Joomla Framework classes do this a lot...

ever used a java website ;-)

@echterhoff I think we can change $filename to $file in the framework but this would and in an information disclosure.

What we can do is to extend the FilesystemException adding the relevant information to it (like the full path) and then expose this information in the cms if needed.

I'm closing this pr because it can't be merged but discussion should continue.