[#34257] - [4.0] mod_popular with disabled hits
- Fixed in Code Base
- 29 May 2021
- Medium
- Build: 4.0-dev
- # 34257
- Diff
- brianteeman:hits_module
User tests: Successful: Unsuccessful:
When hits are disabled for articles (in the article options) it makes no sense to display the Most Read Articles module in the site or admin as the contents will never be updated.
This PR changes the output of the module so that instead of a list of non-updating articles a message is displayed.
Site Module
Admin Module
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Modules Layout Front End |
| Labels |
Added:
?
?
|
||
The module seems to be very old and there are only few use cases when it makes sense, with or without hit counting. I suggest removing it from the dashboard for new installations. @richard67 what do you think?
@chmst I think that with hit count it sill makes sense and I would like to have that module on my dashboard because I have it for my homepage, too. But that's just my personal opinion, I have nothing to decide and I don't want to have anything to decide.
I actually use it a lot - so maybe others so as well - dont really care if its default or not. Either way its beyond the scope of this PR to remove it
It is not in scope of this PR, just a matter of taste.
we really have to get out of the habit of out of scope comments. Far too often they completely detract from the actual PR. my 2c
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34257.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34257.
Should the module be displayed on the front end in this case?
Absolutely yes. Think like a user.
I turn off hits in January. In December I decide to add the module but it doesn't appear anywhere - joomla is broken.
This way it appears and they are informed that they need to re-enable hits
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34257.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-29 17:00:36 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
?
|
||
Thanks!
Thanks
With maintainers like these it's pointless.
Thanks for the flowers.
I dont believe anyone is a mind reader. If there is something wrong then say it
For once - I agree with Sharky. This broke things. PR incoming :-(
thats why you have to speak and not thumbs
The module seems to be very old and there are only few use cases when it makes sense, with or without hit counting. I suggest removing it from the dashboard for new installations. @richard67 what do you think?