[#34248] - [4.0] global menu options
- New
- Medium
- Build: staging
- # 34248
Steps to reproduce the issue
Step 1
Go to the global options for a menu item and set a value for all 4 options
Step 2
Create a new menu item and check the settings in the page display tab - expected behaviour would be to see the values from step 1
Step 3
Now we know that the page heading and page class global settings are ignored - what about the browser title that is at least displayed in the menu item options. Nope thats ignored
Summary
The only one of the four options that actually does anything is the third one "Show Page Heading" but even that doesnt really doing anything as it is meaningless without a value for "Page Heading"
Conclusion
There is zero point in having any of these global options for a menu item as they dont work as their is no code to use them and they can be removed - unless I have missed something
System information (as much as possible)
Additional comments
joomla-cms-bot
- | Labels |
Added:
?
|
||
are you sure they work in j3? The broken behaviour seems identical to me.
They don't work in J3 either, at least in content. @tonypartridge magine that all sites have the same title? a11y and seo ....
Finally found what happens and where.
Before a PR I would like to get your opinion if we can remove the site title form gobal params. Equal title for all pages is an accessibility issue if it works. @brianteeman
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34248.
I agree equal titles is wrong. Hard to confirm that this param creates that though as I dont see where it can be used
It does. I will prepare a draft PR.and let the param, then you can see it.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34248.
great
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-02-01 23:03:48 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
No Code Attached Yet
Removed: ? |
||
| Status | Closed | ⇒ | New |
| Closed_Date | 2022-02-01 23:03:48 | ⇒ | |
| Closed_By | brianteeman | ⇒ |
Re-opening this issue since the PR has been closed without merging.
| Labels |
Added:
bug
|
||
They used to work in J3, so I’d expect them to work in J4... we have actually be using them for meta management and page H1’s.
And page class to define custom classes within the theme...
Wouldn’t it make more sense to add the support rather than remove it?