[#34246] - [4.0] alert-warning colors fix
- Fixed in Code Base
- 31 May 2021
- Medium
- Build: 4.0-dev
- # 34246
- Diff
- himanshu007-creator:mudtext
User tests: Successful: Unsuccessful:
Pull Request for Issue #34174.
Summary of Changes
As discussed here
Changed the warning accent color to yellow and text color to mud yellow.
Testing Instructions
- build css
npm run build:css - check the warning alert ( you can try to login to backend with wrong credetials for example)
- notice the colors of warning alert
Actual result BEFORE applying this Pull Request
A mud(ish) yellow color accent color (#996900)
Expected result AFTER applying this Pull Request
Yellow color in general and text color + dismiss button to mud(ish) yellow (#996900)
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
The
!importantis unacceptable
Made the changes
I have tested this item
With Pull Request
Without Pull Request
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34246.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34246.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34246.
Quy
- | Status | Ready to Commit | ⇒ | Pending |
| Labels |
Added:
?
|
||
Is the pull request ready for a re-test?
The dismiss button must have the darker colour too.
The dismiss button must have the darker colour too.
will do it, Thanks
| Labels |
Removed:
?
|
||
@sandramay0905 , @YatharthVyas please test this PR again.
Thanks
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34246.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34246.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34246.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-31 08:09:00 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
The
!importantis unacceptable