? ? ? Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
26 May 2021

Summary of Changes

The old path is for J3. Update location path for J4.

Testing Instructions

Code review.

or

Install Testing Sample Data.
Go to System > Manage > Extensions
Search and disable Wrapper - Site.
Go to System > Manage > Site Modules
Go to the Wrapper row.
Hover mouse over the disabled icon under Status column.

Actual result BEFORE applying this Pull Request

manage-extensions

avatar Quy Quy - open - 26 May 2021
avatar Quy Quy - change - 26 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 May 2021
Category Administration Language & Strings
avatar brianteeman brianteeman - test_item - 26 May 2021 - Tested successfully
avatar brianteeman
brianteeman - comment - 26 May 2021

I have tested this item successfully on c1c2112

Marking as a successful test

but it really needs to be changed from a title to make it accessible and usable. Also you don't normally get information on anything disabled and the grey colour makes this look disabled so the title is unexpected


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34238.

avatar richard67 richard67 - test_item - 26 May 2021 - Tested successfully
avatar richard67
richard67 - comment - 26 May 2021

I have tested this item successfully on c1c2112


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34238.

avatar richard67 richard67 - change - 26 May 2021
Status Pending Ready to Commit
Labels Added: ? ?
avatar richard67
richard67 - comment - 26 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34238.

avatar infograf768
infograf768 - comment - 27 May 2021

Thought:

There are other ways to get to Manage -> Extensions than passing by the default admin Joomla menu System > Manage > Extensions .

For example, when using the Alternative Main Menu, it is Extensions > Manage > Manage
Or in case of a custom admin menu, it can be Manage > Extensions

All have evidently the same url index.php?option=com_installer&view=manage

It would be nice to use a link with the url as second variable in the sprintf.

This evidently if we can click on that link.

The problem is that it is a tip created as Title and therefore can't be clicked.
Any idea how to improve this?

avatar brianteeman
brianteeman - comment - 27 May 2021

@infograf768 see #34240 that would allow your suggestion

avatar infograf768
infograf768 - comment - 27 May 2021

I was thinking of something like this

extensions-manage

avatar infograf768
infograf768 - comment - 27 May 2021

code would be something like

diff --git a/administrator/components/com_modules/tmpl/modules/default.php b/administrator/components/com_modules/tmpl/modules/default.php
index 05a53b5..ebb7513 100644
--- a/administrator/components/com_modules/tmpl/modules/default.php
+++ b/administrator/components/com_modules/tmpl/modules/default.php
@@ -124,7 +124,15 @@
 							<?php else : ?>
 								<?php // Extension is not enabled, show a message that indicates this. ?>
-								<span class="tbody-icon" title="<?php echo Text::sprintf('COM_MODULES_MSG_MANAGE_EXTENSION_DISABLED', $this->escape($item->name)); ?>">
-									<span class="icon-minus-circle" aria-hidden="true"></span>
-								</span>
+								<div class="dropdown">
+									<button role="button" data-bs-toggle="dropdown" aria-expanded="false" class="icon-minus-circle btn-sm dropdown-toggle">
+									</button>
+									<ul class="dropdown-menu dropdown-menu-end" style="position: absolute; inset: 0px auto auto 0px; margin: 0px; transform: translate(-228px, 27px);" data-popper-placement="bottom-start">
+										<li>
+											<button type="button" class="dropdown-item" title="Extensions: Manage">
+												<a href="<?php echo Route::_('index.php?option=com_installer&view=manage'); ?>"><?php echo Text::sprintf('COM_MODULES_MSG_MANAGE_EXTENSION_DISABLED', $this->escape($item->name)); ?></a>
+											</button>
+										</li>
+									</ul>
+								</div>
 							<?php endif; ?>
 						</td>
avatar Quy
Quy - comment - 28 May 2021

While functional, it feels clunky. Maybe keep the tooltip and click the button to go to the Extensions list.

avatar infograf768
infograf768 - comment - 28 May 2021

Here is another solution.
The tooltip is now in a similar format as the other status icons tooltips (aria-labelledby).
Clicking on the icon redirects to Manage => Extensions
The only visual difference is the cursor. Therefore we may need to modify the tip to let users know that clicking on the icon will redirect to Manage => Extensions

Code would be something like

diff --git a/administrator/components/com_modules/tmpl/modules/default.php b/administrator/components/com_modules/tmpl/modules/default.php
index 05a53b5..2c46970 100644
--- a/administrator/components/com_modules/tmpl/modules/default.php
+++ b/administrator/components/com_modules/tmpl/modules/default.php
@@ -124,7 +124,11 @@
 							<?php else : ?>
 								<?php // Extension is not enabled, show a message that indicates this. ?>
-								<span class="tbody-icon" title="<?php echo Text::sprintf('COM_MODULES_MSG_MANAGE_EXTENSION_DISABLED', $this->escape($item->name)); ?>">
+								<a class="tbody-icon" href="javascript:void(0);" onClick="location.href='<?php echo Route::_('index.php?option=com_installer&view=manage'); ?>'"
+									aria-labelledby="disabled-<?php echo $this->escape($item->name); ?>">
 									<span class="icon-minus-circle" aria-hidden="true"></span>
-								</span>
+								</a>
+								<div id="disabled-<?php echo $this->escape($item->name); ?>" role="tooltip">
+									<?php echo Text::sprintf('COM_MODULES_MSG_MANAGE_EXTENSION_DISABLED', $this->escape($item->name)); ?>
+								</div>
 							<?php endif; ?>
 						</td>

and result

extensions-manage2

NOTE-UNRELATED ISSUE:

I discovered an important bug when working on this.
It happens when we have one module disabled in the displayed list. That module has no checkbox.
Clicking on blank space in any row ticks the checkbox of the row immediately at the bottom.
Clicking on a checkbox ALSO checks the checkbox below.

sitemodules_tick_issue

Release blocker??

avatar brianteeman
brianteeman - comment - 28 May 2021

The second unrelated issue is already reported

avatar infograf768
infograf768 - comment - 28 May 2021

Found where it is reported
#30798
but not solved...

avatar infograf768
infograf768 - comment - 28 May 2021

For the checkboxes, we could simply use #30798 (comment)

avatar rdeutz rdeutz - change - 29 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-29 07:56:54
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 29 May 2021
avatar rdeutz rdeutz - merge - 29 May 2021

Add a Comment

Login with GitHub to post a comment