Feeling Lucky
?
[#34232] - [4.0] Respect detectDebug
- Closed
- 26 May 2021
- Medium
- Build: 4.0-dev
- # 34232
- Diff
- dgrammatiko:—fix-ordering-bug—4.0-dev
User tests: Successful: Unsuccessful:
Pull Request for Issue #34228 .
Summary of Changes
Fixes the ordering
Testing Instructions
Check that HTMLHelper::_('script', 'media/system/js/showon.js', ['detectDebug' => false]); respects the rule and the non minified is served
Also check that HTMLHelper::_('script', 'media/system/js/showon.js'); loads the minified
Enable the DEBUG and check that the non minified is served
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
dgrammatiko
- comment
- 26 May 2021
Closing as it's not really working (?)
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-26 17:23:42 |
| Closed_By | ⇒ | dgrammatiko | |
| Labels |
Added:
?
|
||
This doesn't work:
loads showon.js when JDEBUG is false and showon.min.js when JDEBUG is true.
The way it was was correct, this patch 'inverts' the file selection.