[#34225] - [ALL] PHP Version Check
- Closed
- 26 May 2021
- Medium
- Build: staging
- # 34225
Before attempting a PR can people confirm my finding and that I have not made a silly mistake.
The plugin quickicon check is supposed to give a warning once the php version reaches the security only date and an error message when it reaches the end of support date.
As far as I can tell the security only warning message can never be displayed because the code is wrong.
This applies to all versions 3.9x, 3.10, 4.x
The easiest way to confirm this is to change the dates for your version of php in the plugin code.
joomla-cms-bot
- | Labels |
Added:
?
|
||
That is what the code is doing because it is broken.
It was certainly written to display the end of support information originally and I didnt see a PR that states an intentional change to that behaviour
This plugin checks three conditions: whether the PHP version is still fully supported, whether it has entered security support only, or whether it is unsupported by the PHP project.
#11498 (comment)
Why else do we have the string
oh wait - i misunderstood you - checking
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-26 11:02:23 |
| Closed_By | ⇒ | brianteeman |
I get it now - sorry for the confusion. It displays the security notice 3 months before the end of life. I get it now. Sorry for disturbing
The security date is not used but the warning is shown 3 month before end of support. I'm not sure if it's useful to show a "in security only mode" message a year in advanced before the php versions is eol. The 3 month should be enough.