? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
25 May 2021

This PR adds the tree prefix to the second line of the title (exactly as is done in com_menus)

It also removes a title on a div which makes zero sense at all.

Before

image

After

image

avatar brianteeman brianteeman - open - 25 May 2021
avatar brianteeman brianteeman - change - 25 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 May 2021
Category Administration com_categories
avatar PhilETaylor
PhilETaylor - comment - 25 May 2021

Could space be saved having it all on one line? just a thought

avatar PhilETaylor PhilETaylor - test_item - 25 May 2021 - Tested successfully
avatar PhilETaylor
PhilETaylor - comment - 25 May 2021

I have tested this item successfully on 615d0cd

It works, only thing I would comment is that the three dots used the for building out the tree and the three dots used to indicate a row can be drag/dropped are the same...

Screenshot 2021-05-25 at 20 27 25

Also looks like there are now two items at each level, maybe the second line could be indented without the three dots and hyphen?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34212.
avatar brianteeman
brianteeman - comment - 25 May 2021

Also looks like there are now two items at each level, maybe the second line could be indented without the three dots and hyphen?

This is just implementing the exact same stuff as in the menu manager.

avatar PhilETaylor
PhilETaylor - comment - 25 May 2021

Yeah I understand that. Im just being picky with the concept, not the PR.

avatar brianteeman
brianteeman - comment - 25 May 2021

please be picky in your own issue ;) sick of other people derailing valid pr with off topic posts

avatar ChristineWk ChristineWk - test_item - 25 May 2021 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 25 May 2021

I have tested this item successfully on 615d0cd

It looks more structured now


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34212.

avatar Quy Quy - change - 25 May 2021
Status Pending Ready to Commit
Labels Added: ?
avatar Quy
Quy - comment - 25 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34212.

avatar rdeutz rdeutz - change - 26 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-26 12:41:18
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 26 May 2021
avatar rdeutz rdeutz - merge - 26 May 2021

Add a Comment

Login with GitHub to post a comment