? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
25 May 2021

Content and Contacts have an option labeled "Subcategories Text"

What it does is to add the h3 heading "Subcategories" above the list of subcategories

This PR changes the text to be "Subcategories Heading" which I believe is a more accurate description.

Because the key for the language string is a global string and misnamed as JGLOBAL_SHOW_CATEGORY_HEADING_TITLE_TEXT_LABEL and not SUBcategory I added a new string.

The name of the field, also misnamed as show_category_heading_title_text, has not been changed as that would break b/c for no good reason.

Finally, I suspect because of the incorrect name, the option was not being displayed in the correct, and consistent, place in the form and this PR fixes that as well.

There is no change to anything on the frontend

avatar brianteeman brianteeman - open - 25 May 2021
avatar brianteeman brianteeman - change - 25 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 May 2021
Category Administration com_contact com_content Language & Strings Front End
avatar PhilETaylor
PhilETaylor - comment - 25 May 2021

Unrelated to this PR, RIPS is moaning since 3.9.27 release. Reported. Drone failing.


Failure: Number of issues exceeds sum threshold (1/0)
--
25 | Please contact the security team at security@joomla.org
26 | Progress: [============================] 100%

avatar PhilETaylor PhilETaylor - test_item - 25 May 2021 - Tested successfully
avatar PhilETaylor
PhilETaylor - comment - 25 May 2021

I have tested this item successfully on 46a4c5f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34209.

avatar ChristineWk ChristineWk - test_item - 25 May 2021 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 25 May 2021

I have tested this item successfully on 46a4c5f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34209.

avatar Quy Quy - change - 25 May 2021
Status Pending Ready to Commit
Labels Added: ?
avatar Quy
Quy - comment - 25 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34209.

avatar rdeutz rdeutz - change - 26 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-26 11:54:21
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 26 May 2021
avatar rdeutz rdeutz - merge - 26 May 2021
avatar brianteeman
brianteeman - comment - 26 May 2021

Thank you

Add a Comment

Login with GitHub to post a comment