[#34205] - [4.0] Remove Fieldsets from Two Factor Authentication Steps
- Fixed in Code Base
- 26 May 2021
- Medium
- Build: 4.0-dev
- # 34205
- Diff
- YatharthVyas:fieldset-scope
User tests: Successful: Unsuccessful:
Pull Request for Issue #34187
Summary of Changes
Removes fieldset from 'Steps' and the parent fieldset now only encloses the authentication method dropdown and the security code field. ie. Everything except for One time emergency passwords
Changed
<fieldset>
<legend> LEGEND_TEXT </legend>
...
</fieldset>to
<hr>
<h3>
LEGEND_TEXT
</h3>
...Testing Instructions
- Make sure the Yubikey and Google Two Factor Authentication Plugins are Enabled
- Backend -> Users -> Manage -> Select any User to Edit -> Visit the Two Factor Authentication Tab\
- Try all options for the Authentication Method Dropdown and ensure that the headings are corrected formatted.
Actual result BEFORE applying this Pull Request
The Steps displayed on selecting each 2FA method are displayed as fieldsets. See #34187 (comment)
Expected result AFTER applying this Pull Request
The Steps look similar to how they did in Joomla 3
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_users Front End Plugins |
I have tested this item
Thank you!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34205.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34205.
the fix does not looks right,
I think, you better check the styling, instead of removing fieldsets
@Fedik I think it was done here in this way due to @brianteeman comment here: #34187 (comment) .
@richard67 then I hide my comment ;)
Sorry, but the changes in user/edit.php in the two-factor tab are not correct.
Fieldsets are not there for decoration - they group input fields (a11y). The input fields authentication method and security code belong together.
But I think we could remove the fieldset completely, as the form has only one selection and one input field but surely a fieldset around the first field makes no sense. If it is for the layout and decorative, then use css.
| Labels |
Added:
?
|
||
@YatharthVyas Don't forget to adapt the summary of changes in the description to the latest change. Thanks in advance.
@richard67 Done
| Status | Ready to Commit | ⇒ | Pending |
Back to pending due to changes. @sandramay0905 @Kostelano I'd be happy if you could test again. Thanks in advance.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34205.
Just checked the whole user edit again, and sorry for confusion.
Could you please revert the changes and make the fieldset as it was before, around the two input fields? The different tabs in user edit schould be consitent.
| Labels |
Removed:
?
|
||
The fieldset now only surrounds the Dropdown and all the steps that include the security code input. I have also updated the PR description and the 'Expected result AFTER applying this Pull Request'.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34205.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34205.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34205.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-26 18:12:26 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
?
|
||
Thank you!
Thanks all
I have tested this item✅ successfully on 2141a01
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34205.