User tests: Successful: Unsuccessful:
Pull Request for Issue # .
This PR improves the code of contact view of com_contact component (mostly relate to handle breadcrumb). The code which we are having right now is a mess, hard to understand and difficult to maintain:
The new code is base on the current code which we are having in view article in com_content. It is much easier to understand compare to the original code.
For contact accessed base on the first two menu item types, the breadcrumb displayed in the breadcrumb has this format:
Home / Active Menu Item / [Sub Category] / Contact Name
For contact accessed from Single Contact menu item type, the breadcrumb should have this format:
Home / Active Menu Item
Works but code looks bad.
Works and code is cleaner, easier to understand.
Status | New | ⇒ | Pending |
Category | ⇒ | Front End com_contact |
Labels |
Added:
?
|
@sandramay0905 Yes. This PR just improves code. So Yes, it works exactly the same as without patch.
I have tested this item
I guess this needs no retest cause only @since
changed.
@sandramay0905 Thanks. Yes. You don't need to re-test. We can restore your previous test result because last change is just a small code style change only.
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-31 19:54:03 |
Closed_By | ⇒ | wilsonge | |
Labels |
Added:
?
|
Thanks!
Works like without patch.
If a contact-category have no menu-item like one of the two categories, the breadcrumb show for a single contact
Home / Contact
.What i mean:
Contact-Tree
breadcrumbs show after click on category "Business"Home / Contact Tree / Business
Home / Contact
.@joomdonation If this is expected, i can submit a successfully test result.