Feeling Lucky
?
?
[#34196] - [4.0] Disallow using dashes in template name
- Fixed in Code Base
- 25 May 2021
- Medium
- Build: 4.0-dev
- # 34196
- Diff
- joomdonation:disallow_dash_for_template_name
User tests: Successful: Unsuccessful:
Pull Request for Issue #32621.
Summary of Changes
Using dash "-" character in template causes potential issue as described at #32621 . This PR adds validation to prevent using that character in template name. In general, we only accept Letters, numbers and underscore for template name as displayed in UI.
Testing Instructions
- Go to System -> Site Templates -> Cassiopeia Details and Files
- Click on Copy Template button in the toolbar to create a copy of the template
- Enter a template name contains - character, for example test-template-name
- Before patch: Template is created
- After patch: Template could not be created, there is error message displayed Invalid template name. Please use only letters, numbers and underscores
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_templates Language & Strings |
Abernyte-Git
- comment
- 25 May 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34196.
| Status | Pending | ⇒ | Ready to Commit |
joomdonation
- comment
- 25 May 2021
RTC. Thanks !
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34196.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-25 16:44:31 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
|
||
wilsonge
- comment
- 25 May 2021
Thanks!
I have tested this item✅ successfully on 407c5a3
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34196.