No Code Attached Yet
avatar PhilETaylor
PhilETaylor
24 May 2021

Code review

The method \Joomla\CMS\Filter\InputFilter\Cli::serialize calls $this->loadAllInputs(); but the method loadAllInputs doesnt exist anywhere in the Joomla (or libraries) code base and therefore would generate a fatal error message.

	public function serialize()
	{
		// Load all of the inputs.
		$this->loadAllInputs();

		// Remove $_ENV and $_SERVER from the inputs.
		$inputs = $this->inputs;
		unset($inputs['env']);
		unset($inputs['server']);

		// Serialize the executable, args, options, data, and inputs.
		return serialize(array($this->executable, $this->args, $this->options, $this->data, $inputs));
	}

$this->loadAllInputs();

avatar PhilETaylor PhilETaylor - open - 24 May 2021
avatar joomla-cms-bot joomla-cms-bot - change - 24 May 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 24 May 2021
avatar PhilETaylor PhilETaylor - change - 24 May 2021
The description was changed
avatar PhilETaylor PhilETaylor - edited - 24 May 2021
avatar PhilETaylor PhilETaylor - change - 7 Mar 2022
Status New Closed
Closed_Date 0000-00-00 00:00:00 2022-03-07 18:37:00
Closed_By PhilETaylor
Labels Added: No Code Attached Yet
Removed: ?
avatar PhilETaylor PhilETaylor - close - 7 Mar 2022

Add a Comment

Login with GitHub to post a comment