[#34163] - [4] Remove non existing class import
- Fixed in Code Base
- 31 May 2021
- Medium
- Build: 4.0-dev
- # 34163
- Diff
- PhilETaylor:24may-removenonexitingclass
User tests: Successful: Unsuccessful:
Code review
This class doesnt exist, and is not used in the file anyway as the only one that is, is \Joomla\CMS\Input\Cli which itself is deprecated with a note to use this non existing class \Joomla\Input\Cli /facepalm
Related to #34162
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34163.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34163.
Maybe better to remove the full class path here
instead of removeing the class import?
I think you need more coffee.
instead of removeing the class import?
use Joomla\Input\Cli; is being removed by this PR because that class doesn't exist at all. Doing anything "instead" would be wrong.
Maybe better to remove the full class path
If I just removed the full class path, and did not remove the class import then you would create a fatal error in the code, as the Joomla\Input\Cli class simply doesnt exist!
\Joomla\CMS\Input\Cli is being used on line 129 COULD be imported, but then so could all the Session classes above it and I get told off by "maintainers" for importing classes because "that causes too much work with merging up" - and that would be out of scope of this already RTC PR.
Removing a reference to a class that totally doesnt exist, is more important I would say then simplifying fully qualified class names.
However you are the maintainer, and you have "Allow edits by maintainers" rights.. .so do as you wish to this already RTC PR.
Good suggestion with the coffee
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-31 11:17:08 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 1abc627
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34163.