Feeling Lucky
?
[#3416] - [#33583] [imp] Use a class variable for the published column
- Closed
- 27 Jul 2014
- Medium
- Build: staging
- # 3416
- Diff
- wilsonge:tablepublished
- Foreign ID 33583
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
See the discussion at #3414
Testing
- Apply Patch
- Test in any current component (except banners) that hits, published and checkin and checkout continue to function as expected - this will test that the batch is completely b/c with current components
- Test publishing an item in banners. This will test that using the new single variable rather than a 70 line overriding function works as expected
| Labels |
Added:
?
?
|
||
| Description | ⇒ | <p>See the discussion at <a href="https://github.com/joomla/joomla-cms/pull/3414" class="issue-link" title="Conversation starter for JTable::publish() revision">#3414</a></p> |
| Title |
|
||||||
| Description | <p>See the discussion at <a href="https://github.com/joomla/joomla-cms/pull/3414" class="issue-link" title="Conversation starter for JTable::publish() revision">#3414</a></p> <p>Unfortunately my laptop is busted. So I can't test this - only with what travis says and what common sense says</p> | ⇒ | <p><a href="http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33583&start=0">http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33583&start=0</a></p> <p>See the discussion at <a href="https://github.com/joomla/joomla-cms/pull/3414" class="issue-link" title="Conversation starter for JTable::publish() revision">#3414</a></p> <p>Unfortunately my laptop is busted. So I can't test this - only with what travis says and what common sense says</p> | ||||
| Labels |
Added:
?
Removed: ? |
||||||
beat
- comment
- 23 Apr 2014
This is a nice improvement compared to 100% hardcoded column names in JTable.
it's a good step (that can be approved as is), but a small step. I'm also a believer of decoupling, and the JTableObserver class could be used to implement each of those features completely uncoupled from JTable and reusable for e.g. each flag in a table. In this particular case of "hardcoded" table columns in e.g. JTableBanner, similarly to what I have done for Tags.
b2z
- comment
- 27 Jul 2014
How to test?
wilsonge
- comment
- 27 Jul 2014
See Joomla Code :) I'll copy and paste into github tho
| Description | <p><a href="http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33583&start=0">http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33583&start=0</a></p> <p>See the discussion at <a href="https://github.com/joomla/joomla-cms/pull/3414" class="issue-link" title="Conversation starter for JTable::publish() revision">#3414</a></p> <p>Unfortunately my laptop is busted. So I can't test this - only with what travis says and what common sense says</p> | ⇒ | <p><a href="http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33583&start=0">http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33583&start=0</a></p> <p>See the discussion at <a href="https://github.com/joomla/joomla-cms/pull/3414" class="issue-link" title="Conversation starter for JTable::publish() revision">#3414</a></p> <h2>Testing</h2> <ol class="task-list"> <li>Apply Patch</li> <li>Test in any current component (except banners) that hits, published and checkin and checkout continue to function as expected - this will test that the batch is completely b/c with current components</li> <li>Test publishing an item in banners. This will test that using the new single variable rather than a 70 line overriding function works as expected</li> </ol> |
Kubik-Rubik
- comment
- 27 Jul 2014
Still works with the new improvements. Great job, thanks!
Bakual
- comment
- 27 Jul 2014
Merged into 3.4-dev.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-07-27 15:27:15 |
Now is perfect!! +