[#34148] - [4] filter to bool the cache_platformprefix and debug_lang_const on save
- Fixed in Code Base
- 31 May 2021
- Medium
- Build: 4.0-dev
- # 34148
- Diff
- PhilETaylor:converttobool
User tests: Successful: Unsuccessful:
Summary of Changes
Pull Request for Issue #34134
Testing Instructions
Install joomla 4
View configuration.php
Login to admin
save global configuration with no changes
see the https://gist.github.com/PhilETaylor/95609cc3d716e985aa348da5b839cced/revisions
as you can see debug_lang_const and cache_platformprefix on clean installation are booleans
After saving Joomla global configuration, they are converted and stored as integers.
Actual result BEFORE applying this Pull Request
public $debug_lang_const = 1;
public $cache_platformprefix = 1;Expected result AFTER applying this Pull Request
public $debug_lang_const = true;
public $cache_platformprefix = true;Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_config |
If you changed the saved value, you should also change the code where the config option is used. For example https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/src/Language/Language.php#L327
while I agree - also have to take #34134 (comment) into account so cannot always assume they will be booleans ... yet :(
@PhilETaylor I'm aware of that. As long as you are not using strict comparison, I think we should be fine.
| Labels |
Added:
?
|
||
| Category | Administration com_config | ⇒ | Administration com_config Installation Libraries |
@joomdonation done
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34148.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34148.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34148.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34148.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-31 08:07:56 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
drone failure unrelated to PR content :)