Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#34142] - [4.0] atum Remove underline from badges

NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar himanshu007-creator
himanshu007-creator
23 May 2021

Pull Request for Issue #34137 .

Summary of Changes

Removed underline style from Badge

Testing Instructions

  • Apply patch
  • Build css npm run build:css
  • Navigate to Home Dashboard
  • notice the badges in site information

ADDITIONAL checks
go to User Menu>Accesssibility> Highlight Links , enable it and notice the badges again. Having highlight links enables, text now is underligned.

Actual result BEFORE applying this Pull Request

text in Badges were underlined

Expected result AFTER applying this Pull Request

Underline style is removed

Documentation Changes Required

none

avatar himanshu007-creator himanshu007-creator - open - 23 May 2021
avatar himanshu007-creator himanshu007-creator - change - 23 May 2021
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 May 2021
Category ⇒ Administration Templates (admin) NPM Change
avatar brianteeman brianteeman - test_item - 23 May 2021 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 23 May 2021

I have tested this item ? unsuccessfully on a5de3f5

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34142.

avatar brianteeman
brianteeman - comment - 23 May 2021

This needs to be more specific as it removes the text-decoration in lots of other places in the other cpanel dashboards.

perhaps .cpanel-modules .list-group-item.btn

avatar himanshu007-creator himanshu007-creator - change - 23 May 2021
Labels Added: NPM Resource Changed ?
4c1995b 23 May 2021 avatar himanshu007-creator lint
avatar himanshu007-creator
himanshu007-creator - comment - 25 May 2021

@brianteeman Please test again. Thanks

avatar Quy Quy - test_item - 5 Jun 2021 - Tested successfully
avatar Quy
Quy - comment - 5 Jun 2021

I have tested this item ✅ successfully on 4c1995b

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34142.

avatar sandramay0905 sandramay0905 - test_item - 6 Jun 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 6 Jun 2021

I have tested this item ✅ successfully on 4c1995b

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34142.

avatar richard67 richard67 - change - 6 Jun 2021
Status Pending ⇒ Ready to Commit
avatar richard67
richard67 - comment - 6 Jun 2021

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34142.

avatar chmst chmst - close - 6 Jun 2021
avatar chmst chmst - merge - 6 Jun 2021
avatar chmst chmst - change - 6 Jun 2021
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-06-06 21:06:27
Closed_By ⇒ chmst
Labels Added: ?
avatar chmst
chmst - comment - 6 Jun 2021

Thanks!

Add a Comment

Login with GitHub to post a comment