? ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
23 May 2021

Summary of Changes

add autocomplete and required attributes to username/password fields in the Joomla update process

Testing Instructions

Upgrade Joomla, checking the username and password fields before/after in the captive pages.

Actual result BEFORE applying this Pull Request

No required and autocomplete attributes.

Expected result AFTER applying this Pull Request

Required and autocomplete attributes applied to fields.

Documentation Changes Required

none

avatar PhilETaylor PhilETaylor - open - 23 May 2021
avatar PhilETaylor PhilETaylor - change - 23 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 May 2021
Category Administration com_joomlaupdate
avatar brianteeman
brianteeman - comment - 23 May 2021

If I remember correctly it was deliberate not to have autocomplete

avatar PhilETaylor
PhilETaylor - comment - 23 May 2021

With the uprising of password managers, I no longer see a valid reason for it not to have them.

avatar Abernyte-Git Abernyte-Git - test_item - 28 May 2021 - Tested successfully
avatar Abernyte-Git
Abernyte-Git - comment - 28 May 2021

I have tested this item successfully on 5c9f118


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34140.

avatar sandramay0905 sandramay0905 - test_item - 29 May 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 29 May 2021

I have tested this item successfully on 5c9f118


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34140.

avatar richard67
richard67 - comment - 29 May 2021

@brianteeman Possibly this decision was made at a time when not all browsers supported autocomplete in the right way? Do you know or remember any details?

avatar richard67 richard67 - change - 29 May 2021
The description was changed
Status Pending Ready to Commit
Labels Added: ?
avatar richard67 richard67 - edited - 29 May 2021
avatar richard67
richard67 - comment - 29 May 2021

Assuming that all browser supported by J4 support autocomplete, I set this RTC.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34140.

avatar richard67 richard67 - change - 29 May 2021
The description was changed
Status Ready to Commit Pending
avatar richard67 richard67 - edited - 29 May 2021
avatar richard67
richard67 - comment - 29 May 2021

Back to pending until discussed with SST. Thanks @brianteeman for the links.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34140.

avatar PhilETaylor
PhilETaylor - comment - 29 May 2021

But yet the login form uses autocomplete and password auto fill /fail

Can't have it both ways!

avatar richard67
richard67 - comment - 29 May 2021

@brianteeman When following your link, I read:

For this reason, many modern browsers do not support autocomplete="off" for login fields
...
The browser still offers to remember this login.

All in all the article describes how to disable the autofill property and that this can be a bit tricky, and so not providing it doesn't necessarily mean it is disabled for all browsers, and so I think this PR doesn't do any harm but fixes it by providing the correct hint to the browser.

avatar richard67 richard67 - change - 29 May 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 29 May 2021

RTC again. Final decision takes the one who reviews again and merges.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34140.

avatar brianteeman
brianteeman - comment - 29 May 2021

If I remember correctly it was deliberate not to have autocomplete

I found the reason in the history and it was raised by many people - however it does not apply here

avatar richard67
richard67 - comment - 29 May 2021

Thanks for checking and reporting back.

avatar rdeutz rdeutz - change - 31 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-31 08:02:21
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 31 May 2021
avatar rdeutz rdeutz - merge - 31 May 2021

Add a Comment

Login with GitHub to post a comment