User tests: Successful: Unsuccessful:
add autocomplete and required attributes to username/password fields in the Joomla update process
Upgrade Joomla, checking the username and password fields before/after in the captive pages.
No required and autocomplete attributes.
Required and autocomplete attributes applied to fields.
none
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_joomlaupdate |
With the uprising of password managers, I no longer see a valid reason for it not to have them.
I have tested this item
I have tested this item
@brianteeman Possibly this decision was made at a time when not all browsers supported autocomplete in the right way? Do you know or remember any details?
Status | Pending | ⇒ | Ready to Commit |
Labels |
Added:
?
|
Assuming that all browser supported by J4 support autocomplete, I set this RTC.
Status | Ready to Commit | ⇒ | Pending |
Back to pending until discussed with SST. Thanks @brianteeman for the links.
But yet the login form uses autocomplete and password auto fill /fail
Can't have it both ways!
@brianteeman When following your link, I read:
For this reason, many modern browsers do not support autocomplete="off" for login fields
...
The browser still offers to remember this login.
All in all the article describes how to disable the autofill property and that this can be a bit tricky, and so not providing it doesn't necessarily mean it is disabled for all browsers, and so I think this PR doesn't do any harm but fixes it by providing the correct hint to the browser.
Status | Pending | ⇒ | Ready to Commit |
RTC again. Final decision takes the one who reviews again and merges.
If I remember correctly it was deliberate not to have autocomplete
I found the reason in the history and it was raised by many people - however it does not apply here
Thanks for checking and reporting back.
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-31 08:02:21 |
Closed_By | ⇒ | rdeutz | |
Labels |
Added:
?
|
If I remember correctly it was deliberate not to have autocomplete