? Success

User tests: Successful: Unsuccessful:

avatar eitamar
eitamar
6 Apr 2014

when creating new article same query runs 50-60 times..

tracked down the problem to a line of code that is not being used anyhow so i deleted it.
now we need to test and see if there is no side effects for this action.

avatar eitamar eitamar - open - 6 Apr 2014
avatar wilsonge
wilsonge - comment - 8 Apr 2014

If this isn't used this is awesome. But it would also be nice to test this as well #2789 which cache's the results of that query

avatar eitamar
eitamar - comment - 8 Apr 2014

PR #2789 is changing 3 files, none of them is access.php which this PR is changing. so i guess testing is all we need to do.

avatar mbabker
mbabker - comment - 8 Apr 2014

If the call is unused, let's remove it (so test this patch). Even one extra query that can be saved helps performance in our system :-)

avatar brianteeman
brianteeman - comment - 10 Apr 2014

I believe that this has just been resolved on another issue #2789

Please can you confirm that this resolves the issue

avatar wilsonge
wilsonge - comment - 10 Apr 2014

The multiple queries will be resolved. But this means no queries at all (rather than 1). So we should still test this as Michael said :)

avatar eitamar
eitamar - comment - 10 Apr 2014

i've tested it and #2789 fix the repeated query. so no need to apply this patch too.

avatar nicksavov nicksavov - change - 21 Aug 2014
Labels Removed: ?
avatar brianteeman brianteeman - change - 21 Aug 2014
Status New Pending
avatar brianteeman brianteeman - change - 2 Sep 2014
Category SQL
avatar brianteeman
brianteeman - comment - 16 Oct 2014

As the original poster @eitamar has stated that this has been fixed elsewhere I am closing this.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3412.

avatar jissues-bot jissues-bot - close - 16 Oct 2014
avatar brianteeman brianteeman - change - 16 Oct 2014
Status Pending Closed
avatar jissues-bot jissues-bot - change - 16 Oct 2014
Closed_Date 0000-00-00 00:00:00 2014-10-16 23:15:45
avatar jissues-bot
jissues-bot - comment - 16 Oct 2014
avatar wilsonge
wilsonge - comment - 17 Oct 2014

Just as feedback in case anyone comes back to this in the future - it was a bug that the variable wasn't used in the first place. This has since been fixed by @nikosdion in 2411f29

Add a Comment

Login with GitHub to post a comment