Feeling Lucky
?
?
[#34118] - [4] remove method allow parent to run
- Fixed in Code Base
- 29 May 2021
- Medium
- Build: 4.0-dev
- # 34118
- Diff
- PhilETaylor:remove_method2
User tests: Successful: Unsuccessful:
Code review.
This code is not needed, the parent class _getList can be used instead.
$odd is not actually used in the view either.
//cc @joomdonation
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content |
richard67
- comment
- 23 May 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34118.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
richard67
- comment
- 23 May 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34118.
| Labels |
Added:
?
|
||
richard67
- comment
- 26 May 2021
@PhilETaylor After your other PR #34060 has been merged, this one had a conflict. I've allowed myself to solve it and think I did it right. But I'd feel safer if you could have a quick look on it. The diff on GitHub looks strange but I think that's just GitHub.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-29 06:52:48 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
Removed: ? |
||
I have tested this item✅ successfully on f6effc7
Thanks.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34118.