? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
22 May 2021

Before this PR a jpeg image would not have a thumbnail image in the media manager AND the icon for editing an image was missing.

This PR has sql changes but does not have an update sql as its changing userdata

To test either do a complete fresh install OR go to the options for media manager and DELETE the Legal Image Extensions (File Types) and then save

Pull Request for Issue #34107

avatar brianteeman brianteeman - open - 22 May 2021
avatar brianteeman brianteeman - change - 22 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 May 2021
Category Administration com_media SQL Installation Postgresql
avatar sandramay0905 sandramay0905 - test_item - 23 May 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 23 May 2021

I have tested this item successfully on 1d8b07a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34113.

avatar Abernyte-Git Abernyte-Git - test_item - 23 May 2021 - Tested successfully
avatar Abernyte-Git
Abernyte-Git - comment - 23 May 2021

I have tested this item successfully on 1d8b07a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34113.

avatar PhilETaylor
PhilETaylor - comment - 23 May 2021

Its 2021, maybe we should consider also allowing the modern jpg versions ?

I wonder what versions of image the JS libraries we use for image manipulation can cope with?

https://en.wikipedia.org/wiki/JPEG_2000

Sample images
http://opf-labs.org/format-corpus/jp2k-formats/

avatar richard67 richard67 - change - 23 May 2021
Status Pending Ready to Commit
Labels Added: ?
avatar richard67
richard67 - comment - 23 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34113.

avatar richard67
richard67 - comment - 23 May 2021

This PR has sql changes but does not have an update sql as its changing userdata

@brianteeman I fully agree in this case here. It would be too risky to try to update that, and it would not really be necessary because nothing is broken which was working before if we don't update that data.

avatar Quy Quy - change - 23 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-23 13:09:43
Closed_By Quy
Labels Added: ?
avatar Quy Quy - close - 23 May 2021
avatar Quy Quy - merge - 23 May 2021
avatar Quy
Quy - comment - 23 May 2021

Thanks!

avatar brianteeman
brianteeman - comment - 23 May 2021

thanks

Add a Comment

Login with GitHub to post a comment