? ? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
21 May 2021

Pull Request for #33978 (comment) .

Summary of Changes

This pull request changes blog sample data so it uses for the "Main Menu Blog" the new "collapse-metismenu" layout of the Cassiopeia template which has been recently added by PR #33978. This makes this menu module collapsible and so behave like it was before that PR .

In addition, an update SQL script is added to update any menu module on module position "menu" which uses the "cassiopeia:dropdown-metismenu" layout to the new "collapse-metismenu" layout. Before PR #33978 , only menus on position "menu" were collapsible, therefore the limitation of this update SQL to modules on that position. Furthermore, the update is limited to modules using the "cassiopeia:dropdown-metismenu" layout in order not to risk updating menu modules with the default layout when other templates than Cassiopeia are used, i.e. any modules using the default layout will not be updated to the new "collapse-default" layout of the module.

Finally, the SQL statement in the "base.sql" script to insert the module for the main menu of the site is on new installation is changed to make sure that this module uses the non-collapsible default layout so that it behaves in the same way as before PR #33978 and because a collapsible menu on the right sidebar doesn't make much sense.

Testing Instructions

Step 1: Make a new installation with the current 4.0-dev branch or a nightly build of today, May 22, or later.

Step 2: Install "Sample Data Blog".

Step 3: Check the horizontal menu in the header section of the frontend on mobile screen size.

Result: The menu is not collapsed and there is no "burger" button.

Step 4: Check which layout is used for the "Main Menu Blog" module.

Result: The non-collapsible "Dropdown" layout of the "Cassiopeia" template is used.

Step 5: Create a few copies of the "Main Menu Blog" module at different module positions.

Step 6: Update to the patched package for this PR using the package or the custom update URL created by drone.

Step 7: Check again the horizontal menu in the header section of the frontend on mobile screen size (if necessary reload the page).

Result: The menu is collapsed and there is a "burger" button.

Step 8: Check in backend which layout is used for the "Main Menu Blog" module.

Result: The "Collapsible Dropdown" layout of the "Cassiopeia" template is used.

Step 9: Check which layouts are used by the other frontend menu modules.

Result: For other modules nothing has changed, they still use non-collapsible layouts.

Step 12: Make again a new installation using the full package built by drone for this PR or by applying the patch of this PR to a clean 4.0-dev branch again. It will not work if you continue with the result from the previous steps because the installation folder either has been deleted at the end of step 1 or it will be without the changes of this PR because the update package doesn't update any installation folder.

Step 13: Install "Sample Data Blog".

Step 14: Check in backend which layout is used for the "Main Menu Blog" module.

Result: The "Collapsible Dropdown" layout of the "Cassiopeia" template is used.

Actual result BEFORE applying this Pull Request

After the update e.g. from 4.0 Beta 7 or a nightly build from before May 22nd to the nightly of May 22 or later, a menu module with the "Dropdown" layout of the "Cassiopeia" template on module position "Menu" like e.g. the "Main Menu Blog" from a "Sample Data Blog" installation is not collapsible anymore like it was before that update, i.e. there is no "burger" button on mobile screens:

pr-34086_02

The same applies to a new installation of current 4.0-dev or a nightly of today (May 22) or later after installation of "Sample Data Blog".

Expected result AFTER applying this Pull Request

After the update e.g. from 4.0 Beta 7 or a nightly build from before May 22nd or a current 4.0-dev branch to the patched package of this PR, a menu module with the "Dropdown" layout of the "Cassiopeia" template on module position "Menu" like e.g. the "Main Menu Blog" from a "Sample Data Blog" installation remains collapsible like it was before that update, i.e. there is still a "burger" button on mobile screens:

pr-34086_01

The same applies to a new installation of current 4.0-dev or a nightly of today (May 22) or later after installation of "Sample Data Blog".

Documentation Changes Required

None.

avatar richard67 richard67 - open - 21 May 2021
avatar richard67 richard67 - change - 21 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 May 2021
Category SQL Administration com_admin Postgresql Front End Plugins
avatar richard67 richard67 - change - 21 May 2021
The description was changed
avatar richard67 richard67 - edited - 21 May 2021
avatar chmst
chmst - comment - 22 May 2021

What do you think about an additional note on the template params page of cassiopeia with information for on the layouts?

avatar richard67
richard67 - comment - 22 May 2021

What do you think about an additional note on the template params page of cassiopeia with information for on the layouts?

I'm not in favour of that. We should have some documentation on it of course, but I think that should not be in the backend.

avatar richard67 richard67 - change - 22 May 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 22 May 2021
Category SQL Administration com_admin Postgresql Front End Plugins SQL Administration com_admin Postgresql Installation Front End Plugins
avatar richard67 richard67 - change - 22 May 2021
The description was changed
avatar richard67 richard67 - edited - 22 May 2021
avatar richard67 richard67 - change - 22 May 2021
The description was changed
avatar richard67 richard67 - edited - 22 May 2021
avatar richard67 richard67 - change - 22 May 2021
The description was changed
avatar richard67 richard67 - edited - 22 May 2021
avatar richard67 richard67 - change - 22 May 2021
The description was changed
avatar richard67 richard67 - edited - 22 May 2021
avatar richard67 richard67 - change - 22 May 2021
The description was changed
avatar richard67 richard67 - edited - 22 May 2021
avatar richard67 richard67 - change - 22 May 2021
Title
[4.0] [WiP] Adapt blog sample data and modules on position "menu" to new collapsible menu layouts
[4.0] Adapt blog sample data and modules on position "menu" to new collapsible menu layouts
avatar richard67 richard67 - edited - 22 May 2021
avatar richard67 richard67 - change - 22 May 2021
Title
[4.0] Adapt blog sample data and modules on position "menu" to new collapsible menu layouts
[4.0] Adapt blog sample data and dropdown menus on position "menu" to new collapsible menu layouts
avatar richard67 richard67 - edited - 22 May 2021
avatar chmst chmst - test_item - 23 May 2021 - Tested successfully
avatar chmst
chmst - comment - 23 May 2021

I have tested this item successfully on a61c1c1

Thank you, works as described. Tested on MariaDB only.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34086.
avatar richard67 richard67 - change - 23 May 2021
The description was changed
avatar richard67 richard67 - edited - 23 May 2021
avatar sandramay0905 sandramay0905 - test_item - 24 May 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 24 May 2021

I have tested this item successfully on a61c1c1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34086.

avatar richard67 richard67 - change - 24 May 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 24 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34086.

avatar drmenzelit drmenzelit - change - 25 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-25 09:46:21
Closed_By drmenzelit
Labels Added: ?
avatar drmenzelit drmenzelit - close - 25 May 2021
avatar drmenzelit drmenzelit - merge - 25 May 2021
avatar drmenzelit
drmenzelit - comment - 25 May 2021

Thanks

avatar richard67
richard67 - comment - 25 May 2021

Thanks all.

Add a Comment

Login with GitHub to post a comment