Feeling Lucky
?
[#34084] - [4.0] Lack of documentation in showon.js
- Closed
- 1 Jul 2021
- Medium
- Build: staging
- # 34084
The problem
A method in showon.js file has empty documentation comment.
I think that the comment should have a description of what the method does
joomla-cms-bot
- | Labels |
Added:
?
|
||
eopws
- comment
- 22 May 2021
So what linkedOptions(key) is doing is initialize the showon behaviour for the given HTMLElement
Yes, but I think that the comment https://github.com/joomla/joomla-cms/blob/4.0-dev/build/media_source/system/js/showon.es6.js#L114-L117 should have that info too.
At line 101 there is a comment // Initialise
Don't you think that the comment is too small and creates ambiguity (initialise what?).
alikon
- | Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-07-01 12:04:04 |
| Closed_By | ⇒ | alikon |
At line 101 there is a comment
// Initialisejoomla-cms/build/media_source/system/js/showon.es6.js
Line 101 in 24830a9
So what
linkedOptions(key)is doing isinitialize the showon behaviour for the given HTMLElement