[#34077] - [4] Remove more deprecated code slated for removal in Joomla 4
- Closed
- 7 Mar 2022
- Medium
- Build: 4.0-dev
- # 34077
- Diff
- PhilETaylor:removedeprecated7
User tests: Successful: Unsuccessful:
Code review
Like the code said "As of 3.7.0, passing a null value for the first argument of %1$s() is deprecated and will not be supported in 4.0."
This PR cleans up and enforces this deprecation and fixes the docblocks
$jsSafe is slated as a bool, but the code has code to use it as an array, but its never used as an array by Joomla core so I have not type hinted it just yet, to allow 3PD calling it
Now if you call Text::script(); you will correctly get
Too few arguments to function Joomla\CMS\Language\Text::script(), 0 passed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
Hey @PhilETaylor How can we test this?
Code review
Also try calling Text::script(); (with no arguments) before and after applying the PR and compare the difference.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34077.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34077.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34077.
Could you please resolve the conflicts
| Labels |
Added:
?
Conflicting Files
Removed: ? |
||
Conflicts Resolved.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-07 18:33:38 |
| Closed_By | ⇒ | PhilETaylor | |
| Labels |
Added:
?
Removed: Conflicting Files |
||
Hey @PhilETaylor How can we test this? I know writing testing instructions isn't fun, but it will insure not so skilled people can also test and PR's get committed faster.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34077.