[#34074] - [4] print_popup function missing, provide exception
- Fixed in Code Base
- 21 May 2021
- Medium
- Build: 4.0-dev
- # 34074
- Diff
- PhilETaylor:removedeprecated6
User tests: Successful: Unsuccessful:
code review.
This is not used by Joomla at all, it might be used by 3PD BUT it would never work and would generate a PHP Fatal error as the method doesnt exist in the class.
Somewhere previously someone decided to deprecate the print_popup method for removal in Joomla 5.
This method calls \Joomla\Component\Content\Administrator\Service\HTML\Icon::print_popup which doesnt exist.
Rather than write that method from scratch, for an obviously deprecated future, I have taken the decision to throw an Exception, instead of a PHP Fatal error which seems to make more sense.
Without this change, if a 3PD were to implement JHtmlIcon::print_popup static method, they would get a PHP Fatal error but now they will get accurate feedback
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content |
I obviously got distracted half way through the sentence. thanks.
Changed to
Without this change, if a 3PD were to implement JHtmlIcon::print_popup static method, they would get a PHP Fatal error but now they will get accurate feedback
I have tested this item
Code review:
- The
self::getIcon()call returns a new object of class\Joomla\Component\Content\Administrator\Service\HTML\Iconhere https://github.com/joomla/joomla-cms/blob/4.0-dev/components/com_content/helpers/icon.php#L102 . - The class is defined here https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_content/src/Service/HTML/Icon.php . It doesn't have a
print_popupmethod and has no parent class which you have one.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34074.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-21 16:28:11 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
@PhilETaylor You wrote in the description:
Is it a typo and you meant "With this change, ..."?