[#34070] - [4] Re-Implement Empty State for Post Installation Messages screen
- Fixed in Code Base
- 23 May 2021
- Medium
- Build: 4.0-dev
- # 34070
- Diff
- PhilETaylor:postinstallemptystate
User tests: Successful: Unsuccessful:
Closes #34048
Summary of Changes
Correctly Implement Empty State for Post Installation Messages.
Previously I implemented this before Empty State design was cemented as a part of Joomla 4, so its not using the same layouts as all the other extensions, this PR makes it now consistent with them.
Testing Instructions
Hide all your post installation messages
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
If you can find a decent documentation page on Post Installation Messages in the doc wiki then let me know and I'll add the Learn More button to it
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_postinstall Language & Strings |
| Title |
|
||||||
I have tested this item
When there are 2 or more components having Post Install Messages and if you hide all messages for the 2nd component, you are no longer able to reset them back. Also, If you hide messages for the first Component instead of the second, ie. Hide for Joomla CMS then you are no longer able to navigate to the 2nd Component's Messages.
Before
After
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34070.
ah yeah... forgot about that - I'll mark the PR as draft and handle that - thanks.
@YatharthVyas can you remember/point me back to my old place I gave you code to add the additional message to your db - save me looking - thanks.
Run this SQL to add a fake post installation message (change the db prefix!)
INSERT INTO `o07n8_postinstall_messages` (`postinstall_message_id`, `extension_id`, `title_key`, `description_key`, `action_key`, `language_extension`, `language_client_id`, `type`, `action_file`, `action`, `condition_file`, `condition_method`, `version_introduced`, `enabled`)
VALUES
(99, 210, 'TEST', 'TEST', '', 'com_cpanel', 1, 'message', '', '', '', '', '4.0.0', 1);
| Labels |
Added:
?
?
|
||
ok I have reworked this now, it is slight different to the other empty states because the model doesnt extend ListModel for some reason, and even if it did, the getItems doesnt use a listQuery, and even if that did, there is still post-processing of the db results before you finally get a list of messages to show.
Essentially all this PR is now doing is replacing the hardcoded HTML with the layout file that already exists for empty state
When you have more than one extension, of course the whole empty state screen will be lower to give room for the dropdown.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34070.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34070.
reworked, to use emptystate layouts like other extensions, only difference is that this needs the additional dropdown if there are multiple extensions with messages
Removed my own ACL check, there was no acl check previously so no need to add one now
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34070.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34070.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34070.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-23 21:03:13 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
I have tested this item✅ successfully on e839d4a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34070.