? Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
20 May 2021

Summary of Changes

The margin/padding in the postinstall empty state is not the same with the other ones.

Testing Instructions

Make sure there are no articles.
Go to Content > Articles
See position of article icon.

Click Post Installation Messages icon.
Click Hide all messages button.
See position of bell icon.

Apply PR.

Positions are consistent.

articles-empty

postinstall-empty

avatar Quy Quy - open - 20 May 2021
avatar Quy Quy - change - 20 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 May 2021
Category Administration com_postinstall
avatar brianteeman
brianteeman - comment - 20 May 2021

screenshots please

avatar Quy Quy - change - 20 May 2021
The description was changed
avatar Quy Quy - edited - 20 May 2021
avatar brianteeman
brianteeman - comment - 20 May 2021

Thanks for the screenshots - makes it much easier to test

avatar sandramay0905 sandramay0905 - test_item - 21 May 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 21 May 2021

I have tested this item successfully on 3d65b42


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34048.

avatar PhilETaylor
PhilETaylor - comment - 21 May 2021

Please close this PR.

Empty State has not been correctly implemented for this extension as it predated the cementing of the concept of Empty State in Joomla 4 by a few days.

I have correctly implemented it in #34070 so this PR is no longer needed, and the padding should now be the same as other screens as we are reusing the empty state layouts

avatar Quy Quy - change - 21 May 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-05-21 14:55:51
Closed_By Quy
Labels Added: ?
avatar Quy Quy - close - 21 May 2021

Add a Comment

Login with GitHub to post a comment