User tests: Successful: Unsuccessful:
Change the last instances of fa-
.
Change fa-8x
to icon-8x
.
Apply coding style.
Install the prebuilt package.
or
Click Post Installation Messages
icon.
Click Hide all messages
button.
Apply PR.
Run npm run build:css
Bell icon should be the same size before/after PR.
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_postinstall Repository NPM Change Layout |
Then they can use fa-7x
, but at least in the core, we are being consistent.
That other pr was reverting poorly implemented code despite multiple people pointing that out in advance ;(
icon- was created to be a bc compatibility layer with iconmoon. it was never intended to be a conversion between fontawesome syntax and iconmoon syntax which is what this pr (and others) are doing
reverting that PR will not achieve that
Then I am lost what the solution should be.
The solution is not to do anything
So it is ok to have mixed icon-
and fa-
in the backend?
yes - I see no reason why not. Especially for the utility classes
Closing then. Thanks!
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-20 17:17:43 |
Closed_By | ⇒ | Quy | |
Labels |
Added:
NPM Resource Changed
?
|
joomla-cms/layouts/joomla/content/emptystate.php
Line 39 in a07bc77