?

Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
20 May 2021

This PR implements the advanced search button in com_finder the correct way. Its a button not a link so it should use the button element. It should also be using aria-expanded.

There is no visible change but it now works correctly.

Reference https://getbootstrap.com/docs/5.0/components/collapse/

image

image

avatar brianteeman brianteeman - open - 20 May 2021
avatar brianteeman brianteeman - change - 20 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 May 2021
Category Front End com_finder
avatar ChristineWk ChristineWk - test_item - 20 May 2021 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 20 May 2021

I have tested this item successfully on 6a0b68d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34036.

Got: <button class="btn btn-secondary" type="button" data-bs-toggle="collapse" data-bs-target="#advancedSearch" aria-expanded="true"> <span class="icon-search-plus" aria-hidden="true"></span>

avatar Abernyte-Git Abernyte-Git - test_item - 20 May 2021 - Tested successfully
avatar Abernyte-Git
Abernyte-Git - comment - 20 May 2021

I have tested this item successfully on 6a0b68d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34036.

avatar richard67 richard67 - change - 20 May 2021
Status Pending Ready to Commit
Labels Added: ?
avatar richard67
richard67 - comment - 20 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34036.

avatar richard67 richard67 - change - 20 May 2021
Status Ready to Commit Pending
avatar richard67
richard67 - comment - 20 May 2021

Back to pending due to review comment.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34036.

avatar brianteeman brianteeman - change - 20 May 2021
Labels Added: ?
avatar Quy Quy - close - 20 May 2021
avatar Quy Quy - merge - 20 May 2021
avatar Quy Quy - change - 20 May 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-20 13:16:22
Closed_By Quy
Labels Removed: ?
avatar Quy
Quy - comment - 20 May 2021

Thanks!

avatar brianteeman
brianteeman - comment - 20 May 2021

thank you

Add a Comment

Login with GitHub to post a comment