Feeling Lucky
?
[#34036] - [4.0] com_finder advanced search [a11y]
- Fixed in Code Base
- 20 May 2021
- Medium
- Build: 4.0-dev
- # 34036
- Diff
- brianteeman:thu9
User tests: Successful: Unsuccessful:
This PR implements the advanced search button in com_finder the correct way. Its a button not a link so it should use the button element. It should also be using aria-expanded.
There is no visible change but it now works correctly.
Reference https://getbootstrap.com/docs/5.0/components/collapse/
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_finder |
Abernyte-Git
- comment
- 20 May 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34036.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
richard67
- comment
- 20 May 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34036.
| Status | Ready to Commit | ⇒ | Pending |
richard67
- comment
- 20 May 2021
Back to pending due to review comment.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34036.
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-20 13:16:22 |
| Closed_By | ⇒ | Quy | |
| Labels |
Removed:
?
|
||
Quy
- comment
- 20 May 2021
Thanks!
brianteeman
- comment
- 20 May 2021
thank you
I have tested this item✅ successfully on 6a0b68d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34036.
Got:
<button class="btn btn-secondary" type="button" data-bs-toggle="collapse" data-bs-target="#advancedSearch" aria-expanded="true"> <span class="icon-search-plus" aria-hidden="true"></span>