? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
20 May 2021

This view was not checking correctly to see if it should output anything for a field. As a result there were a lot of empty rows

To test create a few contacts with various amounts of detail
Create a menu item of type List contacts in a category

When viewed on the frontend you will see numerous blank lines in the details

Apply the pr and those blank lines are removed.

Actual details and fields in the screenshots will depend on the data and menu options

Before

image

After

image

avatar brianteeman brianteeman - open - 20 May 2021
avatar brianteeman brianteeman - change - 20 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 May 2021
Category Front End com_contact
avatar sandramay0905 sandramay0905 - test_item - 20 May 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 20 May 2021

I have tested this item successfully on 892fc2d

Without PR

image

With PR

image


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34030.
avatar ChristineWk ChristineWk - test_item - 20 May 2021 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 20 May 2021

I have tested this item successfully on 892fc2d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34030.

avatar richard67 richard67 - change - 20 May 2021
Status Pending Ready to Commit
Labels Added: ?
avatar richard67
richard67 - comment - 20 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34030.

avatar Quy Quy - change - 20 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-20 12:32:08
Closed_By Quy
Labels Added: ?
avatar Quy Quy - close - 20 May 2021
avatar Quy Quy - merge - 20 May 2021
avatar Quy
Quy - comment - 20 May 2021

Thanks!

avatar brianteeman
brianteeman - comment - 20 May 2021

thank you

Add a Comment

Login with GitHub to post a comment