[#34027] - [4.0] webp banners
- Fixed in Code Base
- 20 May 2021
- Medium
- Build: 4.0-dev
- # 34027
- Diff
- brianteeman:banners2
User tests: Successful: Unsuccessful:
Adds support for webp images in com_banners
code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_banners |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34027.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34027.
Not sure, but on line 47 I see this here:
* @return boolean True if an image of type bmp, gif, jp(e)g or png, false otherwise
Not sure, but on line 47 I see this here:
* @return boolean True if an image of type bmp, gif, jp(e)g or png, false otherwise
@ChristineWk Not related to this PR, but you are right, it should be "True if file of type swf, false otherwise".
@brianteeman Do you wanna fix it with this PR here? Or make a new one?
@richard67 actually there was another PR addressing that - I just forgot to submit it. Doing that now in a new pr
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-20 17:52:27 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on b4f6509
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34027.