? ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
19 May 2021

Code review

avatar PhilETaylor PhilETaylor - open - 19 May 2021
avatar PhilETaylor PhilETaylor - change - 19 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 May 2021
Category Administration
avatar brianteeman
brianteeman - comment - 20 May 2021

I'm sure I was told previously that these should not be changed


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34005.

avatar PhilETaylor PhilETaylor - change - 20 May 2021
Labels Added: ?
avatar PhilETaylor
PhilETaylor - comment - 20 May 2021

@brianteeman that might have been the case at the time, whenever that was, but now this class doesn't exist and there is no alias for it mapping it to the non J prefixed correct class.

9eaaccd 20 May 2021 avatar PhilETaylor more
avatar joomla-cms-bot joomla-cms-bot - change - 20 May 2021
Category Administration Administration Front End
avatar PhilETaylor PhilETaylor - change - 20 May 2021
Title
[4] fixed undefined/wrong exception classname
[4] fixed undefined/wrong exception classname in com_privacy
avatar PhilETaylor PhilETaylor - edited - 20 May 2021
avatar brianteeman
brianteeman - comment - 20 May 2021

there are quite a few other ones to change then ;)

avatar PhilETaylor
PhilETaylor - comment - 20 May 2021

there are quite a few other ones to change then ;)

Such as? or do you simply mean the ones in 9eaaccd that I did not push from my bed last night but did before your comment/

avatar PhilETaylor
PhilETaylor - comment - 20 May 2021

Done.

avatar joomdonation joomdonation - test_item - 20 May 2021 - Tested successfully
avatar joomdonation
joomdonation - comment - 20 May 2021

I have tested this item successfully on c50f3da

Many thanks !


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34005.

avatar richard67 richard67 - test_item - 20 May 2021 - Tested successfully
avatar richard67
richard67 - comment - 20 May 2021

I have tested this item successfully on c50f3da


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34005.

avatar richard67 richard67 - change - 20 May 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 20 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34005.

avatar rdeutz rdeutz - change - 20 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-20 17:47:53
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 20 May 2021
avatar rdeutz rdeutz - merge - 20 May 2021

Add a Comment

Login with GitHub to post a comment