[#33994] - [4] add missing class import for method param type and more cleanup
- Closed
- 3 Jun 2021
- Medium
- Build: 4.0-dev
- # 33994
- Diff
- PhilETaylor:patch-166
User tests: Successful: Unsuccessful:
code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
wilsonge
- | Labels |
Added:
?
|
||
I have rebased this on current 4.0-dev
looks like I screwed it up
| Category | Front End Plugins | ⇒ | Administration com_admin SQL |
| Category | Administration com_admin SQL | ⇒ | Front End Plugins |
ok maybe now?
ok maybe now?
Maybe not. I'm unsure if the changes on plugins/sampledata/blog/blog.php are actual the changes you want (it was not there on your original PR and the change in line 305 I know it's wrong, the other two I'm unsure), so maybe you would want to revert it.
As I can see, there are more problems on plugins/sampledata/multilang/multilang.php. Do you want to look at it and and get it sorted in this PR? (wrong return type declaration, $lang = Factory::getLanguage()->getTag(); , then call $lang->load could cause fatal error....). If not, I will make a PR for that later.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-06-03 08:30:01 |
| Closed_By | ⇒ | PhilETaylor |
ok I'll close this and start from scratch later today
@PhilETaylor Could you please merge this with latest 4.0-dev so that we can review and get this merged? The change on the file plugins/sampledata/blog/blog.php was implement on a different PR and not needed anymore.