[#33980] - [4.0] Change fa-fw to icon-fw
User tests: Successful: Unsuccessful:
Summary of Changes
To remove references to FontAwesome, use generic icon class.
Change fa-fw to icon-fw.
Change order for consistency.
Testing Instructions
Code review.
or
Log in to the administration area.
View Post Installation Messages/Private Messages buttons in the upper right corner.
Icons same before/after PR.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration |
But I couldn't see the Private Messages buttons in the upper right corner.
It is hidden by default when there are no new private messages.
To make it appear, please do the following in this file:
administrator/modules/mod_messages/tmpl/default.php
if ($hideLinks || $countUnread < 1)
to
if ($hideLinks)
I have tested this item
@Quy Thanks for the hint. Changed the code via FTP accordingly.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33980.
OK now:
<span class="icon-envelope icon-fw" aria-hidden="true"></span>
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33980.
I trust if you are going to insist on this pointless change then you will be updating all the other instances in the admin. There is a valid reason to use a generic class in the frontend but none in the admin
Nope. There are only 2 instances of fa- in the backend, thus, this PR. The rest are icon-.
Search again
Well this PR makes these icons consistent with the other icons in the header. I am blind to what you are referring to so please enlighten me.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33980.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33980.
sorry I was searching a branch of mine that had a lot of extensions installed and I didnt realise. There is only one fa- remaining
fa-8x
Mystery solved. I will do a PR for fa-8x. Thank you!
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-20 17:45:14 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
@Quy Sorry, maybe I make something wrong.
Hv now 50:50 :-)
View Post Installation Messages = OK
<span class="icon-bell icon-fw" aria-hidden="true"></span>But I couldn't see the Private Messages buttons in the upper right corner.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33980.