? Success

User tests: Successful: Unsuccessful:

avatar nonumber
nonumber
31 Mar 2014

http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33543&start=0

The color selection popup element doesn't hide correctly in Internet Explorer.
When you click on the icon to show it, then click somewhere to hide it, the click on 'anywhere' will toggle the display of that element.

This fix adds an extra if check to make it only hide when the element is visible.

PS: This PR also includes some general codestyle fixes. The real differens is the extra if in the hide method.

Testing instructions

Either create a module or view that uses the <field name="color" type="color" control="simple" ... /> form element.
Or simply test with Advanced Module Manager (http://www.nonumber.nl/extensions/advancedmodulemanager) that uses this element in the views.
Then play around with it in Internet Explorer.

avatar nonumber nonumber - open - 31 Mar 2014
avatar nonumber nonumber - change - 31 Mar 2014
Labels Added: ? ?
avatar nonumber nonumber - change - 31 Mar 2014
Title
Fixed hide issue in Internet Explorer
Fixed hide issue of the simple color swatch in Internet Explorer
avatar wilsonge
wilsonge - comment - 8 Apr 2014

Test. Works as expected

avatar losedk
losedk - comment - 11 Apr 2014

Tested. Works fine

avatar wilsonge
wilsonge - comment - 11 Apr 2014

RTC

avatar infograf768 infograf768 - change - 13 Apr 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-04-13 09:14:01
avatar infograf768 infograf768 - change - 13 Apr 2014
Title
Fixed hide issue of the simple color swatch in Internet Explorer
[#33543] Fixed hide issue of the simple color swatch in Internet Explorer
avatar infograf768 infograf768 - close - 13 Apr 2014
avatar infograf768 infograf768 - reference | - 13 Apr 14
avatar infograf768 infograf768 - merge - 13 Apr 2014
avatar infograf768 infograf768 - close - 13 Apr 2014
avatar nonumber nonumber - change - 13 Apr 2014
Title
Fixed hide issue of the simple color swatch in Internet Explorer
[#33543] Fixed hide issue of the simple color swatch in Internet Explorer
avatar Bakual Bakual - reference | b723e52 - 12 May 14
avatar nonumber nonumber - head_ref_deleted - 23 Aug 2014

Add a Comment

Login with GitHub to post a comment