Feeling Lucky
?
?
[#33964] - [4] remove no such param from method call
- Fixed in Code Base
- 22 May 2021
- Medium
- Build: 4.0-dev
- # 33964
- Diff
- PhilETaylor:patch-157
User tests: Successful: Unsuccessful:
code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_finder |
joomdonation
- comment
- 19 May 2021
Again, please spend few more time in this and do it right. Thanks
PhilETaylor
- comment
- 19 May 2021
Its been like this for 7 years... its not like there is a rush
| Labels |
Added:
?
|
||
PhilETaylor
- comment
- 19 May 2021
done as requested. ready for testing.
joomdonation
- comment
- 20 May 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33964.
Quy
- comment
- 22 May 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33964.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 22 May 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33964.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-22 18:32:50 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
|
||
Quy
- comment
- 22 May 2021
Thanks!
Yes possibly, however like I said at my other note, this PR only seeks to remove that which is blatantly wrong, and that is never used. Therefore it is easy to test and easy to merge, and breaks nothing! Because the code removed is simply wrong and doesn't actually need to be there