? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
18 May 2021

needs careful code review

avatar PhilETaylor PhilETaylor - open - 18 May 2021
avatar PhilETaylor PhilETaylor - change - 18 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 May 2021
Category Administration com_users
avatar joomdonation joomdonation - test_item - 22 May 2021 - Tested successfully
avatar joomdonation
joomdonation - comment - 22 May 2021

I have tested this item successfully on 4020292


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33954.

avatar joomdonation
joomdonation - comment - 22 May 2021

It is OK. But I have a question which I don't know the answer yet. Isn't Mcrypt not available in from PHP 7.2+ anymore? Maybe we will need to review this case more carefully.

avatar PhilETaylor
PhilETaylor - comment - 22 May 2021

mcrypt can still be used after 7.2 - but you just have to add it manually to PHP if you want it.

This PR is not about mcrypt, its about instantiating the class with the correct number of params.

I believe its a typo Im removing.

avatar joomdonation
joomdonation - comment - 22 May 2021

This PR is not about mcrypt, its about instantiating the class with the correct number of params. I believe its a typo Im removing.

That's right. But the fact is that we still use Mcrypt here, so there could be fatal error in some case. We should review it and solve it (but of course in a different PR)

avatar PhilETaylor PhilETaylor - change - 23 May 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-05-23 21:27:45
Closed_By PhilETaylor
Labels Added: ?
avatar PhilETaylor
PhilETaylor - comment - 23 May 2021

replaced this PR with #34147

avatar PhilETaylor PhilETaylor - close - 23 May 2021

Add a Comment

Login with GitHub to post a comment