[#33954] - [4] Method call is provided 5 parameters, but the method signature uses 4 parameters
- Closed
- 23 May 2021
- Medium
- Build: 4.0-dev
- # 33954
- Diff
- PhilETaylor:patch-150
User tests: Successful: Unsuccessful:
needs careful code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_users |
It is OK. But I have a question which I don't know the answer yet. Isn't Mcrypt not available in from PHP 7.2+ anymore? Maybe we will need to review this case more carefully.
mcrypt can still be used after 7.2 - but you just have to add it manually to PHP if you want it.
This PR is not about mcrypt, its about instantiating the class with the correct number of params.
I believe its a typo Im removing.
This PR is not about mcrypt, its about instantiating the class with the correct number of params. I believe its a typo Im removing.
That's right. But the fact is that we still use Mcrypt here, so there could be fatal error in some case. We should review it and solve it (but of course in a different PR)
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-23 21:27:45 |
| Closed_By | ⇒ | PhilETaylor | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 4020292
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33954.