[#33926] - [4.0] @since
- Fixed in Code Base
- 19 May 2021
- Medium
- Build: 4.0-dev
- # 33926
- Diff
- brianteeman:since
User tests: Successful: Unsuccessful:
Best to start J4 the right way with exact versions for @since
code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_cache com_categories com_checkin com_content com_finder com_menus com_modules com_plugins com_users com_workflow Templates (admin) |
There shouldn't be any
I have tested this item
I looked again and decided the ones I found are not relevant: 3 in api/..., a whole bunch in libraries/src/Console/... and just a few in tests/...
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33926.
I still dont see any
I am using a clone of the joomla-cms repo in conjunction with Eclipse. I search all php files for '[at]since 4.0\n' with regular expression set and come up with this list (partial here just to illustrate findings):
api/components/com_categories/src/Controller/CategoriesController.php line 94
api/components/com_contact/src/Serializer/ContactSerializer.php lines 37, 64, 83, 102, 121
api/components/com_content
api/components/come_contenthistory
more ...
libraries/src/Console/CheckJoomlaUpdatesCommand.php lines 64, 81, 100
more ...
libraries/src/Tag/TagApiSerializerTrait/.php line 34
tests/Unit/Libraries/Cms/Feed/FeedParserTest.php line 387
tests/Unit/Libraries/Cms/Microdata/MicrodataTest.php lines 725, 771
And I have just realised I find some more by searching for '[at]since\ +4.0\n'
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33926.
api/components/com_categories/src/Controller/CategoriesController.php line 94
says 4.0.0
api/components/com_contact/src/Serializer/ContactSerializer.php lines 37, 64, 83, 102, 121
all say 4.0.0
Not bothering to continue as something is not right with your repo if they are saying @since 4.0
It looks like Patchtester has only applied the patches down to and including:
diff --git a/api/components/com_menus/src/Controller/MenusController.php b/api/components/com_menus/src/Controller/MenusController.php
None of the changes below that have been applied. That is just a quarter of the total number of diffs. Hmmmm!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33926.
I wouldnt expect patchtester to work on such a large change
In administrator/components/patchtester/PatchTester/Model/PullModel.php on line 553 the count of files obtained from github is 30. Anything in the PR after that is dropped.
I don't remember seeing this documented anywhere.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33926.
I wouldnt expect patchtester to work on such a large change
Why not? I have just looked at the Patchtester docs and nowhere can I find any mention of any limitations.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33926.
a million reasons and none of them relevant to this PR.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33926.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33926.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-19 22:24:46 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thankyou. Not sure how this crept into so many places!
copy paste to blame
thank you
That leaves 88 to go. Will there be another PR for those? Otherwise I think this is OK.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33926.