[#33923] - Fix Help & System Dashboards preset is not stylized
- Fixed in Code Base
- 17 May 2021
- Medium
- Build: 4.0-dev
- # 33923
- Diff
- eopws:fix-margin-in-menu
User tests: Successful: Unsuccessful:
Pull Request for Issue #33898.
Summary of Changes
Span added when image is not set in order to add margin.
Testing Instructions
Go to the Admin Menu module (control panel), select the Help Dashboard preset in the settings and evaluate the main page of the control panel.
Actual result BEFORE applying this Pull Request
The items in left menu have no left margin.
Expected result AFTER applying this Pull Request
The items in left menu have margin.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33923.
Good idea
<span aria-hidden="true" class="icon-whatever icon-fw"></span>
Or even simpler
<span aria-hidden="true" class="icon-fw"></span>
and then someone in a years time wont try and fix icon-whatever
I've restored the previous test results in the issue tracker since the commit which invalidated them was only a change of a comment.
@eopws Could you have a look on the suggestions above? I think they could be a good improvement for this PR here. Especially see #33923 (comment) . Thanks in advance.
Could you have a look on the suggestions above?
Yes. I'm currently working on this.
IMHO, $itemImage = '<span class="icon-angle-double-right icon-fw" aria-hidden="true"></span>'; is better.
IMHO,
$itemImage = '<span class="icon-angle-double-right icon-fw" aria-hidden="true"></span>';is better.
But then you have to change it to <span class="icon-angle-double-left icon-fw" aria-hidden="true"></span> if the current language has RTL direction.
Seems to work with new commit, but, please, test it.
Not a fan of adding the icon like this. @infograf768 is correct in making it an empty space. The code required to switch between rtl and ltr is simply not justified
Not a fan of adding the icon like this. @infograf768 is correct in making it an empty space. The code required to switch between rtl and ltr is simply not justified
I agree with this statement.
It is distracting to see so many arrows.
Arrows changed to empty space. Please, test.
I have tested this item
Looks good, thanks.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33923.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33923.
| Status | Pending | ⇒ | Ready to Commit |
rtc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33923.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-17 18:21:38 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
|
||
Thanks!
I have tested this item✅ successfully on c64cc36
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33923.