Feeling Lucky
?
Composer Dependency Changed
?
[#33908] - [4.0] php-cs-fixer v3.0 Support
- Fixed in Code Base
- 1 Nov 2021
- Medium
- Build: 4.0-dev
- # 33908
- Diff
- 810:4.0-dev-phpcodefixer
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Now supporting new php-cs-fixer version.
Testing Instructions
Joomla install and then setup you local project.
composer install - then do composer update
Actual result BEFORE applying this Pull Request
depricated PhpCsFixer\Config
Expected result AFTER applying this Pull Request
No errors.
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository External Library Composer Change |
| Labels |
Added:
?
?
|
||
| Title |
|
||||||
brianteeman
- comment
- 13 Jun 2021
guessing that .php-cs-fixer.dist.php should be added the list of files not to be included in a release
| Category | Repository External Library Composer Change | ⇒ | Repository External Library Composer Change Unit Tests |
brianteeman
- comment
- 13 Jun 2021
I have tested this item
Thank you
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33908.
brianteeman
- comment
- 13 Jun 2021
NOTE: I only tested that the PR worked as described. I do not know if the rules are correct for Joomla.
brianteeman
- comment
- 19 Aug 2021
i wish this could be merged and we can fix all the issues
| Labels |
Added:
?
Composer Dependency Changed
?
Removed: ? ? |
||
810
- comment
- 1 Nov 2021
Please merge this.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-11-01 23:54:09 |
| Closed_By | ⇒ | wilsonge |
wilsonge
- comment
- 1 Nov 2021
Thanks!
well if this is actually going to be done, then please check https://github.com/joomla/joomla-cms/pull/33362/files and merge the good parts without the controversy ... the fact is that this project doesn't use php-cs-fixer at all and there is no reason why this configuration should be in this repo, its not used, not even by the maintainers of the CI. And good luck ever getting this merged.