Many code style issues:
1. make sure indentation is done by tabs and not spaces
2. Empty lines should not have tabs
3. use
if ()
{
something
}
else
{
something
}
and not
}else{

1. Missing in tags.php the language load:

/**
* Load the language file on instantiation.
*
* @var boolean
* @since 3.1
*/
protected $autoloadLanguage = true;

1. Alpha order the language strings

See http://joomla.github.io/coding-standards/ for the codestyle standard.
Do you know how check codestyle? Otherwise I can guide you.

I also saw that the PR misses the needed SQL statements to actually install the plugin. You want to add those as well.

Hi Bakual,

i would love some instruction on how to check codestyle standard.

about the SQL thingi, this is the first time i do something like that on a community project - should i just add a line to the sql file where needed, or shuold i follow guidlines and instruction ??

thanks
Itamar

(451, 'plg_search_tags', 'plugin', 'tags', 'search', 0, 1, 1, 0, '', '{"search_limit":"50","show_tagged_items":"1"}', '', '', 0, '0000-00-00 00:00:00', 0, 0);

should be placed just after id 450

The language strings in the ini file needs to be alpha ordered

New update sql files have to be created in
ROOT/administrator/components/com_admin/sql/updates/...

No spaces after opening and before closing parenthesis
instead of
if ( is_array($areas) )
do
if (is_array($areas))

one tab too much in second line here
static $areas = array(
'tags' => 'PLG_SEARCH_TAGS_TAGS'
);
return $areas;


about the SQL thingi, this is the first time i do something like that on a community project - should i just add a line to the sql file where needed, or shuold i follow guidlines and instruction ??

I see you already figured that out and added the files. The same you did should be done for the other database types as well (if you can). I usually do it by copy-pasting similar commands from the other files.
One thing to note is that we usually don't enable new extensions for updating users. Thus the "enabled" column should be set to 0 in the update SQL. But it is fine with 1 in the installation SQL.

As for coding standards, there is a doc how you could install that: http://docs.joomla.org/Joomla_CodeSniffer
Maybe that helps.

I'm going to do some inline comments to show you what you should change. That's the easiest for now.

Bakual: i followed your comment/instructions and commit them - but they give me 3 new white spaces warning when i check the code with the code sniffer.

itamar

You need a whitespace between the switch and the foreach statements and their respective opening bracket as well. Like switch ( and foreach (.
It may coming from this.

Otherwise it looks good now from a codestyle perspective. Thanks

Also, can you move in postgres and sqlazure the new row id 451 at its numeric ordered place?

Tested today on a fresh installation and on an existing installation which worked fine.

I think there is an issue with the database fix method we have. That one screwed up the update SQL commands for some reasons unknown to me (record showed wrong id and name, params were written into manifest cache and state was set to -1). But it looks like an issue with the database fix, not with this PR.
Applying the SQL manually was working fine. Discovering also worked fine.

Merged into 3.3.
Thanks!