User tests: Successful: Unsuccessful:
This PR updates bootstrap to 5.0.1
As expected there are numerous bug fixes - see https://github.com/twbs/bootstrap/releases/tag/v5.0.1
Status | New | ⇒ | Pending |
Category | ⇒ | NPM Change |
The linter really shouldnt be running on vendor files
Emh, the PR is missing the required update in the package.json...
oh - oops
Sometimes when I'm blind I'm at least lucky enough to ping the right people
Labels |
Added:
NPM Resource Changed
?
|
@dgrammatiko The linter still fails with the same error.
I was sure it wasn't me as I had to manually edit the package.json and shouldnt have needed to make a change their.
The linter is correct.
We should not be running the linter on code that is not ours to correct
@richard67 I have 0 clues why this failed here as #33901 it seems fine
I have no clue either.
Might as well close this one then. very odd.
I still dont think our tools should run the linter on vendor files
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-15 10:14:47 |
Closed_By | ⇒ | brianteeman |
We should not be running the linter on code that is not ours to correct
WE AREN'T! We only lint things in the build/media_src
which obviously is Joomla's own code
sorry - I misread the file - /me crawls under a stone
Np, fwiw this wasn't a lint problem but rather an inconsistent version of BS in pagage.json and package.lock
@dgrammatiko Maybe you can help here: The javascript linter consistently fails with: