NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
15 May 2021

This PR updates bootstrap to 5.0.1

As expected there are numerous bug fixes - see https://github.com/twbs/bootstrap/releases/tag/v5.0.1

avatar brianteeman brianteeman - open - 15 May 2021
avatar brianteeman brianteeman - change - 15 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 May 2021
Category NPM Change
avatar richard67
richard67 - comment - 15 May 2021

@dgrammatiko Maybe you can help here: The javascript linter consistently fails with:

+ npm run lint:js

> joomla@4.0.0 lint:js
> eslint --config build/.eslintrc --ignore-pattern '/media/' --ext .es6.js,.es6,.vue .


Oops! Something went wrong! :(

ESLint: 7.26.0

TypeError: Cannot read property 'type' of null
Occurred while linting /********/src/build/media_source/vendor/bootstrap/js/index.es6.js:11
    at isExportNameClass (/********/src/node_modules/eslint-plugin-import/lib/rules/newline-after-import.js:51:69)
    at checkForNewLine (/********/src/node_modules/eslint-plugin-import/lib/rules/newline-after-import.js:79:45)
    at checkImport (/********/src/node_modules/eslint-plugin-import/lib/rules/newline-after-import.js:133:9)
    at /********/src/node_modules/eslint/lib/linter/safe-emitter.js:45:58
    at Array.forEach (<anonymous>)
    at Object.emit (/********/src/node_modules/eslint/lib/linter/safe-emitter.js:45:38)
    at NodeEventGenerator.applySelector (/********/src/node_modules/eslint/lib/linter/node-event-generator.js:256:26)
    at NodeEventGenerator.applySelectors (/********/src/node_modules/eslint/lib/linter/node-event-generator.js:285:22)
    at NodeEventGenerator.enterNode (/********/src/node_modules/eslint/lib/linter/node-event-generator.js:299:14)
    at CodePathAnalyzer.enterNode (/********/src/node_modules/eslint/lib/linter/code-path-analysis/code-path-analyzer.js:711:23)
avatar brianteeman
brianteeman - comment - 15 May 2021

The linter really shouldnt be running on vendor files

avatar dgrammatiko
dgrammatiko - comment - 15 May 2021

Emh, the PR is missing the required update in the package.json...

avatar brianteeman
brianteeman - comment - 15 May 2021

oh - oops

avatar richard67
richard67 - comment - 15 May 2021

Sometimes when I'm blind I'm at least lucky enough to ping the right people ?

31e6309 15 May 2021 avatar brianteeman ,
avatar brianteeman brianteeman - change - 15 May 2021
Labels Added: NPM Resource Changed ?
avatar richard67
richard67 - comment - 15 May 2021

@dgrammatiko The linter still fails with the same error.

avatar brianteeman
brianteeman - comment - 15 May 2021

I was sure it wasn't me as I had to manually edit the package.json and shouldnt have needed to make a change their.

The linter is correct.

We should not be running the linter on code that is not ours to correct

avatar dgrammatiko
dgrammatiko - comment - 15 May 2021

@richard67 I have 0 clues why this failed here as #33901 it seems fine

avatar richard67
richard67 - comment - 15 May 2021

I have no clue either.

avatar brianteeman
brianteeman - comment - 15 May 2021

Might as well close this one then. very odd.

I still dont think our tools should run the linter on vendor files

avatar brianteeman brianteeman - change - 15 May 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-05-15 10:14:47
Closed_By brianteeman
avatar brianteeman brianteeman - close - 15 May 2021
avatar dgrammatiko
dgrammatiko - comment - 15 May 2021

We should not be running the linter on code that is not ours to correct

WE AREN'T! We only lint things in the build/media_src which obviously is Joomla's own code

avatar brianteeman
brianteeman - comment - 15 May 2021

sorry - I misread the file - /me crawls under a stone

avatar dgrammatiko
dgrammatiko - comment - 15 May 2021

Np, fwiw this wasn't a lint problem but rather an inconsistent version of BS in pagage.json and package.lock

Add a Comment

Login with GitHub to post a comment