? Failure

User tests: Successful: Unsuccessful:

avatar deveshprasad
deveshprasad
15 May 2021

Pull Request for Issue #33717.

Summary of Changes

Added Y-axis margin to both the buttons as individual will affect its alignment vertically.
(I have asked on my previous pull request #33824 regarding the method to use as the button.scss file is creating error so followed bootstrap margin)

Testing Instructions

Go to the Post Installation Messages page.

Actual result BEFORE applying this Pull Request

13 05 2021_15 45 42_REC

Expected result AFTER applying this Pull Request

13 05 2021_20 50 17_REC

Documentation Changes Required

No

avatar deveshprasad deveshprasad - open - 15 May 2021
avatar deveshprasad deveshprasad - change - 15 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 May 2021
Category Administration com_postinstall
avatar sandramay0905 sandramay0905 - test_item - 15 May 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 15 May 2021

I have tested this item successfully on 9edac5a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33893.

avatar himanshu007-creator himanshu007-creator - test_item - 15 May 2021 - Tested successfully
avatar himanshu007-creator
himanshu007-creator - comment - 15 May 2021

I have tested this item successfully on 9edac5a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33893.

avatar chmst chmst - change - 15 May 2021
Status Pending Ready to Commit
avatar chmst
chmst - comment - 15 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33893.

avatar HLeithner HLeithner - change - 15 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-15 09:54:13
Closed_By HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 15 May 2021
avatar HLeithner HLeithner - merge - 15 May 2021
avatar HLeithner
HLeithner - comment - 15 May 2021

Thanks

avatar brianteeman
brianteeman - comment - 15 May 2021

This is the wrong approach and should not have been merged. You dont solve a responsive issue by adding a global class. please see #33899

avatar brianteeman
brianteeman - comment - 15 May 2021

By using the correct code you do not need to keep adding classes to buttons. Using only #33899 this is fixed correctly

image

Add a Comment

Login with GitHub to post a comment