? ? Pending

User tests: Successful: Unsuccessful:

avatar deveshprasad
deveshprasad
14 May 2021

Pull Request for Issue #33717.

Summary of Changes

Added Y-axis margin to both the buttons as individual will affect its alignment vertically.
(I have asked on my previous pull request #33824 regarding the method to use as the button.scss file is creating error so followed bootstrap margin)

Testing Instructions

Go to the notifications page

Actual result BEFORE applying this Pull Request

13 05 2021_15 45 42_REC

Expected result AFTER applying this Pull Request

13 05 2021_20 50 17_REC

Documentation Changes Required

No

avatar deveshprasad deveshprasad - open - 14 May 2021
avatar deveshprasad deveshprasad - change - 14 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 May 2021
Category Unit Tests Repository Administration
avatar brianteeman
brianteeman - comment - 14 May 2021

You have submitted this PR against staging instead of 4.0dev

avatar richard67
richard67 - comment - 14 May 2021

@deveshprasad It seems you have made a PR which was meant for 4.0 against the staging branch of this repository, so the PR shows more than 5000 changes files and at the bottom conflicts. Please close it and make again a PR with your branch, but then against the 4.0-dev branch of this repository. This can be done by selecting the right branch for the comparison when creating the PR.

Thanks in advance.

avatar deveshprasad deveshprasad - change - 15 May 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-05-15 06:19:00
Closed_By deveshprasad
Labels Added: ? ?
avatar deveshprasad deveshprasad - close - 15 May 2021

Add a Comment

Login with GitHub to post a comment